From e6e3cf623a56f7b9a5dd60b9ba01967f176fdb7d Mon Sep 17 00:00:00 2001 From: Jared Snider Date: Fri, 24 Jan 2025 16:32:32 -0500 Subject: [PATCH] PM-8113 - Clean up used service method + TODO as I've confirmed it works for other flows. --- .../services/extension-two-factor-auth-component.service.ts | 5 ----- .../two-factor-auth/two-factor-auth-component.service.ts | 5 ----- 2 files changed, 10 deletions(-) diff --git a/apps/browser/src/auth/services/extension-two-factor-auth-component.service.ts b/apps/browser/src/auth/services/extension-two-factor-auth-component.service.ts index f7317c3200b..ee2cc76c7b0 100644 --- a/apps/browser/src/auth/services/extension-two-factor-auth-component.service.ts +++ b/apps/browser/src/auth/services/extension-two-factor-auth-component.service.ts @@ -38,12 +38,7 @@ export class ExtensionTwoFactorAuthComponentService document.body.classList.remove("linux-webauthn"); } - closeWindow(): void { - this.window.close(); - } - async handle2faSuccess(): Promise { - // TODO: confirm that moving this from SSO flow only to general flow doesn't introduce any issues // Force sidebars (FF && Opera) to reload while exempting current window // because we are just going to close the current window if it is in a popout // or navigate forward if it is in the popup diff --git a/libs/auth/src/angular/two-factor-auth/two-factor-auth-component.service.ts b/libs/auth/src/angular/two-factor-auth/two-factor-auth-component.service.ts index 2e71f637ea3..60b2916b697 100644 --- a/libs/auth/src/angular/two-factor-auth/two-factor-auth-component.service.ts +++ b/libs/auth/src/angular/two-factor-auth/two-factor-auth-component.service.ts @@ -29,11 +29,6 @@ export abstract class TwoFactorAuthComponentService { */ abstract removePopupWidthExtension?(): void; - /** - * Optionally closes the window if the client requires it - */ - abstract closeWindow?(): void; - /** * We used to use the user's master key to encrypt their data. We deprecated that approach * and now use a user key. This method should be called if we detect that the user