Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggling password visibility fails to display full password #12641

Closed
1 task done
BenjaminMichaelis opened this issue Dec 31, 2024 · 7 comments · Fixed by #12354
Closed
1 task done

Toggling password visibility fails to display full password #12641

BenjaminMichaelis opened this issue Dec 31, 2024 · 7 comments · Fixed by #12354
Labels
browser Browser Extension bug

Comments

@BenjaminMichaelis
Copy link

Steps To Reproduce

Have a long password stored and toggle visibility button, notice password is not entirely visible like it was in 2024.11.2.

Expected Result

Entire password to be visible like it was in 2024.11.2. and also to match the behavior that occurs on other clients like mobile where entire password is visible.

From 2024.11.2 extension:
image

Actual Result

Password is not entirely visible in 2024.12.4

image

Screenshots or Videos

ios:
iosShowPassword

browser extension:
browserShowPassword

Additional Context

Brought over from Community Forum after pointed out that this could be categorized as a bug:
https://community.bitwarden.com/t/restore-ability-to-see-full-password-when-visibility-is-toggled/78152

Operating System

Windows

Operating System Version

No response

Web Browser

Chrome, Microsoft Edge, Brave

Browser Version

No response

Build Version

2024.12.4

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@BenjaminMichaelis BenjaminMichaelis added browser Browser Extension bug labels Dec 31, 2024
@bitwarden-bot
Copy link

Thank you for reporting this issue! We've added this to our internal tracking system.
ID: PM-16581

@BenjaminMichaelis BenjaminMichaelis changed the title Restore ability to see full password when visibility is toggled Toggling password visibility fails to display full password Jan 1, 2025
@Greenderella
Copy link
Member

Hi there,

Thank you for your report!

I was able to reproduce this issue, and I have flagged this to our engineering team.

If you wish to add any further information/screenshots/recordings etc., please feel free to do so at any time - our engineering team will be happy to review these.

Thanks once again!

@djsmith85 djsmith85 linked a pull request Jan 10, 2025 that will close this issue
@djsmith85
Copy link
Contributor

@BenjaminMichaelis: This has been addressed with #12354 and the changes will be included in the 2025.1-release.

Closing this now.

@BenjaminMichaelis
Copy link
Author

@djsmith85 I loaded 2025.1 and am not seeing this and don't see it explicitly in the release notes on github - is there some feature flag or similar in front of this behavior?

Image

@djsmith85
Copy link
Contributor

Hi @BenjaminMichaelis: I spoke with the team and also tried reproducing this myself with with 2025.1 and wasn't able to:

View item:
Image

As of 2025.1 and greater all users (cloud and self-hosted) should see the new extension UI which is depicted in the 4th screenshot you attached.

Kind regards,
Daniel

@BenjaminMichaelis
Copy link
Author

BenjaminMichaelis commented Jan 23, 2025

Hi @BenjaminMichaelis: I spoke with the team and also tried reproducing this myself with with 2025.1 and wasn't able to:

As of 2025.1 and greater all users (cloud and self-hosted) should see the new extension UI which is depicted in the 4th screenshot you attached.

Kind regards, Daniel

@djsmith85 - Upon closer inspection; I see the detail I missed before; I appreciate you looking into this more.

Where I still see an issue is custom fields, they do not expand like the password field (you are correct that specifically the password field is resolved in 2025.1 and greater). I should of been clear that this was part of the original issue.

Image

Is it worth reopening this issue for that aspect?

@BenjaminMichaelis
Copy link
Author

@djsmith85 I notice also on iOS that it shows the full value for custom fields with no need to scroll; could we match that behavior on the extension as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Browser Extension bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants