Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on the start date at semester 241? #11

Open
hakatu opened this issue Sep 26, 2024 · 2 comments
Open

Issue on the start date at semester 241? #11

hakatu opened this issue Sep 26, 2024 · 2 comments

Comments

@hakatu
Copy link

hakatu commented Sep 26, 2024

Screenshot 2024-09-26 at 15 24 45

Môn học có format tương tự dưới đây báo lỗi khi được nhập vào tkb.

20241_EExxxx_TTxx XX BX-XYZ BX Y 7:00 - 11:50 --|--|--|--|--|--|--|--|43|44|45|46|47|48| 0%

"mình thấy thời khóa biểu của bạn chứa các môn của các học kỳ khác nhau, bắt đầu ngày:
14/10/2024
26/08/2024
bạn chịu khó xóa bớt các dòng của các môn không nằm trong thời khóa biểu này ra khỏi đoạn copy nha."

@hakatu
Copy link
Author

hakatu commented Sep 26, 2024

Possible là từ core
export class MixedSemesterError extends Error { constructor(public doiz1: Date, public doiz2: Date) { super( Semester ambiguity: Two possible semester start dates: ${doiz1.toISOString()} and ${doiz2.toISOString()}, ); } }
Chỉ cần đổi lại check từ mã môn same 20xyz (e.g. 20241) cho các môn trong tkb là được

@iceghost
Copy link
Member

iceghost commented Sep 28, 2024

We could totally parse each row independently with the semester information added.

It was just not obvious to me how to change the interface. Now that I think about it, parse functions now should return multiple timetables instead, and events get merged together. Might need to tweak the iCal code, but yeah, I should get this fixed in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants