Fix D3D12 dynamic texture array update #3182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay3d
pushed a commit
to jay3d/bgfx
that referenced
this pull request
Dec 7, 2023
Co-authored-by: Carlos <[email protected]>
mipek
pushed a commit
to mipek/bgfx
that referenced
this pull request
Mar 2, 2024
Co-authored-by: Carlos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
D3D12 dynamic texture array update had an attempted fix in commit da9e2f0, but it was missing one line of code to make it work, leaving the
layervariable unused. A subsequent commit cleaned up the unused variable. This pull request restores that fix, and uses thelayervariable by doing the same the D3D11 renderer does.Additionally pull request #3026 fixed a loop variable over texture sides from
uint8_ttouint16_t. In the same method there's an identical loop with the same issue, and I also fixed that one.