Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messaging for malformed simfiles #16

Open
bkirz opened this issue Feb 7, 2025 · 0 comments
Open

Improve error messaging for malformed simfiles #16

bkirz opened this issue Feb 7, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@bkirz
Copy link
Owner

bkirz commented Feb 7, 2025

A user uploaded a chart to the mine faker with an orphaned hold head, which raised an OrphanedNoteException and gave them an unhelpful 500 page. We can't and shouldn't attempt to handle all malformed inputs, but our error messaging could be clearer. Maybe we allowlist a set of known error-types and come up with a better error message if one of those is caught?

@bkirz bkirz added the bug Something isn't working label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant