Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proper alignment to root #120

Open
rneher opened this issue Nov 20, 2015 · 5 comments
Open

proper alignment to root #120

rneher opened this issue Nov 20, 2015 · 5 comments

Comments

@rneher
Copy link
Contributor

rneher commented Nov 20, 2015

replace the current alignment algorithm with something that tolerates gaps

@trvrb
Copy link
Member

trvrb commented Dec 23, 2015

Can you say more? You'd like an alignment that maintains gaps? Wouldn't numbering get very complicated in this case?

I guess you could do an alignment that allows gaps then build the tree then remove gaps to get canonical numbering.

@rneher
Copy link
Contributor Author

rneher commented Dec 23, 2015

this refers to the sequence search in javascript. We align to root using a stupid string matching routine and then look for mutations. If the query has a gap relative to root, no proper alignment is found.

@trvrb
Copy link
Member

trvrb commented Sep 23, 2017

This has been resolved in the nextstrain/augur codebase.

@trvrb trvrb closed this as completed Sep 23, 2017
@rneher
Copy link
Contributor Author

rneher commented Sep 23, 2017

I don't think this is resolved. It also refers to sequence search/alignment in auspice rather than augur. This should be a feature request in auspice. I did write a proper pairwise aligner a while back: https://github.com/neherlab/timetree_viewer/blob/master/js/alignPairwise.js

@trvrb trvrb reopened this Sep 23, 2017
@trvrb
Copy link
Member

trvrb commented Sep 23, 2017

I see. Thanks Richard. Just reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants