Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regex based CNAMES are being compared as if they are strings #52

Open
liquidsec opened this issue Aug 5, 2023 · 1 comment
Open

Regex based CNAMES are being compared as if they are strings #52

liquidsec opened this issue Aug 5, 2023 · 1 comment
Assignees
@liquidsec
Labels
bug Something isn't working on-hold

Comments

@liquidsec
Copy link
Collaborator

Add separate logic comparing cnames against regexes
@liquidsec liquidsec added the bug Something isn't working label Aug 5, 2023
@liquidsec liquidsec added this to the Feature Complete milestone Aug 5, 2023
@liquidsec liquidsec self-assigned this Aug 5, 2023
@liquidsec liquidsec removed this from the Feature Complete (Pre-release) milestone Jan 23, 2024
@liquidsec
Copy link
Collaborator Author

We currently have no signatures which are using regexes for cnames. As a result, we will hold off on this, as it's probably not desirable to use regexes anyway if it can be avoided.

If we need to use a regex here in the future, will revisit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liquidsec liquidsec

Labels
bug Something isn't working on-hold
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@liquidsec