Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update prisma-ast version in blitz package #4382

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

Kosai106
Copy link
Contributor

@Kosai106 Kosai106 commented Oct 10, 2024

Follow-up to: #3882

Closes: #3190

What are the changes and their implications?

Updated the version of prisma-ast used in blitz to align it with @blitzjs/generator in the hopes it'll stop the following error from happening:

Error generating get__ModelName__.ts
MismatchedTokenException: Expecting --> ')' <-- but found --> '0' <--

This version is severely outdated and the library should be bumped to the latest (v0.12.0) at some point.

Bug Checklist

  • Changeset added (run pnpm changeset in the root directory)
  • Integration test added (see test docs if needed)

Feature Checklist

Copy link

changeset-bot bot commented Oct 10, 2024

🦋 Changeset detected

Latest commit: 61726d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
blitz Patch
next-blitz-auth Patch
@blitzjs/auth Patch
@blitzjs/next Patch
@blitzjs/rpc Patch
@blitzjs/codemod Patch
@blitzjs/config Patch
@blitzjs/generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Kosai106
Copy link
Contributor Author

in the hopes it'll stop the following error from happening:

Error generating get__ModelName__.ts
MismatchedTokenException: Expecting --> ')' <-- but found --> '0' <--

Nevermind... The issue was caused by a @default(00001) in my Prisma schema, which should've been @default(1)

Regardless, I think it makes sense to still align the versions.

Copy link
Member

@siddhsuresh siddhsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Kosai106 Kosai106 changed the title chore: update prisma-ast version in blitz config package chore: update prisma-ast version in blitz package Oct 10, 2024
@siddhsuresh siddhsuresh merged commit 50f17d2 into blitz-js:main Oct 14, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade prisma-ast to fix blitz generate failing with prisma keywords as model fields
3 participants