Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Key Overwritten When Creating a Project in Different Browsers with the Same Wallet #139

Open
itailiors opened this issue Aug 22, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@itailiors
Copy link
Collaborator

When a user creates a project in one browser (Browser A) and then goes to a different browser (Browser B) and recovers the wallet using the wallet words, fetches the projects, and creates a new project, an issue occurs. If the user returns to Browser A and attempts to create another project, the new project creation overrides the previously created project key instead of generating a new one. This leads to confusion and potential data loss as the system continues to build on the overridden project key.

Steps to Reproduce:

  1. In Browser A, create a new project.
  2. Switch to Browser B and recover the wallet using the wallet words.
  3. Fetch the projects and create a new project in Browser B.
  4. Return to Browser A and attempt to create another project.

Proposed Fixes:

  • Refetch Projects on Create Button: Add logic to refetch the projects before initiating the creation of a new project to ensure the latest project data is available. (the logic is already added in another PR I opened Fixes for issue 103 and 132 #136 for issue Created Project Not Visible Across Multiple Browsers #103 )
  • Double-Check Before Posting Data: Refactor the project creation process so that no data is posted until all necessary data is collected and verified. This includes a double-check to ensure that a project with the same key has not already been created.
@itailiors itailiors added the bug Something isn't working label Sep 3, 2024
@itailiors
Copy link
Collaborator Author

itailiors commented Dec 6, 2024

should be partially solved in #175

    private async Task NavigateToCreateProject()
    {
        // perform a rescan before creating a project (to update the keys)
        await LookupProjectKeysOnIndexerAsync();

        NavigationManager.NavigateTo("/create");
    }

Still can add before creating the project itself, another scan to check that they key isnt being used

@dangershony
Copy link
Member

@DavidGershony still needs to verify the change in scanning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants