Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typeSpacingRules with more recently added decl types (e.g. typealias) #2803

Closed
deniseli opened this issue Sep 24, 2024 · 1 comment · Fixed by #2874
Closed

Update typeSpacingRules with more recently added decl types (e.g. typealias) #2803

deniseli opened this issue Sep 24, 2024 · 1 comment · Fixed by #2874
Assignees
@deniseli
Labels
P2

Comments

@deniseli
Copy link
Contributor

https://github.com/TBD54566975/ftl/blob/05eee6aa6be61ba3e910c15ac7ffb892b9b9897b/backend/schema/module.go#L86-L95

We've added some decl types since this mapping was last updated. Make sure to update frontend/console/src/features/modules/schema/schema.utils.ts at the same time.
@github-actions github-actions bot added the triage Issue needs triaging label Sep 24, 2024
@ftl-robot ftl-robot mentioned this issue Sep 24, 2024
Open
@bradleydwyer bradleydwyer added P2 next Work that will be be picked up next labels Sep 24, 2024
@github-actions github-actions bot removed triage Issue needs triaging next Work that will be be picked up next labels Sep 24, 2024
@deniseli
Copy link
Contributor Author

plan: instead of adding in new types, just remove all the ones that use the default behavior (verb, enum, data) and add in typealias to have no gap.

@deniseli deniseli mentioned this issue Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deniseli deniseli

Labels
P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update type spacing rules block/ftl
2 participants
@bradleydwyer @deniseli