Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to connect should result into an error with ftl deploy #3142

Closed
jvmakine opened this issue Oct 16, 2024 · 1 comment · Fixed by #3838
Closed

Failure to connect should result into an error with ftl deploy #3142

jvmakine opened this issue Oct 16, 2024 · 1 comment · Fixed by #3838
Assignees
Labels
bug Something isn't working P1

Comments

@jvmakine
Copy link
Contributor

> ftl deploy --endpoint=http://localhost:4678/
info:alice:build: Building module
info:alice:build: Module built (1.99s)
info:alice:deploy: Deploying module
◞[alice] 
>

It seems that the deploy is a success, even if there is nothing listening to port 4678.

We should give a clear error that the CLI failed to connect.

@jvmakine jvmakine added the bug Something isn't working label Oct 16, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Oct 16, 2024
@ftl-robot ftl-robot mentioned this issue Oct 16, 2024
@alecthomas alecthomas added P1 next Work that will be be picked up next and removed triage Issue needs triaging labels Oct 28, 2024
@wesbillman wesbillman self-assigned this Dec 20, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Dec 20, 2024
@wesbillman
Copy link
Collaborator

It seems like wrapped errors aren't getting reported correct when using kctx.FatalIfErrorf(err)

In cli/main.go we have this when calling Run on commands

err = kctx.Run(ctx)
kctx.FatalIfErrorf(err)

If I update this to the following, I then see the messages being printed out:

err = kctx.Run(ctx)
if err != nil {
	fmt.Fprintf(os.Stderr, "ftl: %+v\n", err)
	os.Exit(1)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants