Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JVM plugin should respond to build context changes correctly #3941

Closed
matt2e opened this issue Jan 8, 2025 · 0 comments · Fixed by #4011
Closed

JVM plugin should respond to build context changes correctly #3941

matt2e opened this issue Jan 8, 2025 · 0 comments · Fixed by #4011
Labels
jvm

Comments

@matt2e
Copy link
Collaborator

matt2e commented Jan 8, 2025

Reading the code it doesn't look like it but we need to confirm.

Expected: whenever build context changes, plugin should attempt to build and send the result back with the flag IsAutomaticRebuild set to false
Looks like the code is written to always send true after the initial build attempt, regardless of whether the build context changed.
@matt2e matt2e added the jvm label Jan 8, 2025
@matt2e matt2e self-assigned this Jan 8, 2025
@matt2e matt2e changed the title Confirm if jvm plugin handles build context changes correctly JVM plugin should respond to build context changes correctly Jan 8, 2025
This was referenced Jan 8, 2025
Open
Open
@matt2e matt2e removed their assignment Jan 13, 2025
stuartwdouglas added a commit that referenced this issue Jan 14, 2025
@stuartwdouglas
fix: send a build response when context changes
968e201 
fixes #3941
@stuartwdouglas stuartwdouglas mentioned this issue Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
jvm
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: send a build response when context changes block/ftl
1 participant
@matt2e