Fix cicd #1
Merged
Fix cicd #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pikonha
reviewed
Oct 18, 2024
.github/workflows/test.yml
Outdated
| node-version: '18' | ||
|
|
||
| - name: Install dependencies | ||
| run: npm install --frozen-lockfile |
There was a problem hiding this comment.
I saw that you have a bun.lock file on the root of the repo, which makes me think that you're using bun instead of npm. Is that right?
| on: workflow_dispatch | ||
| on: | ||
| push: | ||
| branches: [main] |
There was a problem hiding this comment.
Not ideally. But can happen hueuheuehu
| @@ -30,5 +43,5 @@ jobs: | |||
|
|
|||
| - name: Run Forge tests | |||
| run: | | |||
| forge test -vvv | |||
| forge test --fork-url ${{secrets.RPC_OP}} -vvv --via-ir | |||
There was a problem hiding this comment.
didn't know about the test's fork flag, does this mean the tests are being run on the testnet?
There was a problem hiding this comment.
It means that, for the test scope, we will fork the network's state. We are not running it in the testnet, but locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request to fix the CI / CD powered by github actions (it was not broken).