Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling the "Close modal" button in onboard modals #270

Open
liamaharon opened this issue Jun 12, 2019 · 2 comments
Open

Allow disabling the "Close modal" button in onboard modals #270

liamaharon opened this issue Jun 12, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@liamaharon
Copy link
Contributor

It sometimes makes sense for the completion of onboarding to be compulsory, where the dev doesn't want to handle a 'onboard failed' scenario. This could be achieved by adding the option to disable to top right "close modal" button from the onboard modals.

@liamaharon liamaharon added the enhancement New feature or request label Jun 12, 2019
@liamaharon liamaharon changed the title Optionally disable the "Close modal" button Allow disabling the "Close modal" button in onboard modals Jun 12, 2019
@cmeisl
Copy link
Member

cmeisl commented Jun 12, 2019

@liamaharon Do we have an actual use case here from any of our integrations?

@liamaharon
Copy link
Contributor Author

@cmeisl yes, on some pages space-miners and now mintable require the user to be onboarded before the page loads. if the user fails to onboard, the app falls into an error state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants