Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Use EIP55 when displaying and returning public address #1586

Open
kabaluyot opened this issue Mar 14, 2023 · 3 comments
Open

[Feature]: Use EIP55 when displaying and returning public address #1586

kabaluyot opened this issue Mar 14, 2023 · 3 comments
Labels
documentation Improvements or additions to documentation enhancement Something could be made better feature New feature or request

Comments

@kabaluyot
Copy link
Contributor

Is your request related to a problem?

Atm, web3-onboard (in access control or rpc) returns lowered case public address. For consistency with smart contracts and other evm tools, it should be returning the EIP55 checksum address.

Feature Description

No response

Alternative Solutions

No response

Anything else?

No response

@kabaluyot kabaluyot added the feature New feature or request label Mar 14, 2023
@Adamj1232
Copy link
Member

@kabaluyot thanks for this request! I will discuss with the team and get it prioritized in our backlog.
Is the current behavior causing any issues in usage? This will help with prioritizing.
Thank you!

@kabaluyot
Copy link
Contributor Author

Hi Adam. Not a blocker issue cause anytime when doing comparison check with address from contract we can just use to lower case etc. or with ether.utils.getAddress(>web3onboard returned address>) to get EIP55 address, but it would be nice that it returns the standard EIP55 address so it we consistent with most wallets and other evm tools.

One possible usecase here is when saving connected wallet to a database (say a dapp that returns auth token). Without explicitly converting to EIP55 address, the record in database will be a all-small letter address. When verifying signatures, the address is also needed to be converted ..

@gesquinca gesquinca added the enhancement Something could be made better label Mar 23, 2023
@gesquinca gesquinca added the documentation Improvements or additions to documentation label May 11, 2023
@ricardo-cavalheiro
Copy link

One possible usecase here is when saving connected wallet to a database (say a dapp that returns auth token). Without explicitly converting to EIP55 address, the record in database will be a all-small letter address. When verifying signatures, the address is also needed to be converted ..

Today our team faced the exact same problem you described. I guess it's a good thing to be EIP-55 compliant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement Something could be made better feature New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants