Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ledger] Show derivation path instead of Ledger Live #1818

Open
roheat opened this issue Jul 8, 2023 · 1 comment
Open

[Ledger] Show derivation path instead of Ledger Live #1818

roheat opened this issue Jul 8, 2023 · 1 comment
Assignees
Labels
feature New feature or request

Comments

@roheat
Copy link

roheat commented Jul 8, 2023

Is your request related to a problem?

I want to bump my ledger package from @2.3.2 to @2.5.1 for the WalletConnect v2 support.
However, my dapp users prefer selecting the derivation path and choosing the account without having to install Ledger Live App (which introduced in 2.4.0+).

@2.3.2
Screenshot 2023-07-08 at 2 18 41 PM

@2.5.1
Screenshot 2023-07-08 at 2 23 02 PM

Feature Description

Can you introduce a key in the module options to fallback to older derivation path logic for ledger?

const ledger = ledgerModule({
  projectId: 'abc123...',
  requiredChains: [1, 137],
  ledgerLive: false // can be true by default
})

Alternative Solutions

No response

Anything else?

No response

@roheat roheat added the feature New feature or request label Jul 8, 2023
@Adamj1232
Copy link
Member

@roheat thank you for the open issue. We will discuss with the team and get back to you. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants