-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS Safari modal placement #1885
Comments
@qruz-hq Im not sure why your app isn't displaying your site as a mobile app but the web3-onboard connect modal should look like this on mobile. You can give our app a test at reactdemo.blocknative.com or here and see the codebase here - https://github.com/blocknative/react-demo |
Can you send a full list of all of you web3-onboard package versions and a reproducible example or codebase? |
@qruz-hq friendly ping on the above notes and request |
Hi @qruz-hq friendly ping on the above questions. Would love to help get you squared away if possible. |
@qruz-hq we are going to go ahead and close this issue because of lack of response. Please feel free to continue the conversation if the problem persists. |
Hey sorry I was out for a moment. This is the full modal, with the option |
We don't display a modal on mobile. On mobile it should always look like the image above. Are you saying on mobile setting |
This isn't a "mobile" issue in itself, it's a iOS Safari (and maybe other browsers) issue. There's no way of fixing this because the page height doesn't change when you scroll up on the page, that's just how the Safari development team made their app I guess. Using a fixed element with a The way Safari works is when you scroll down the URL bar disappears and it reappears when you scroll up. It visually reduces the viewport height but it keeps the same px value. Hence why it gets hidden. |
Can we reopen this pls 🙇 |
Current Behavior
As seen on the image the modal get hidden on the new safari UI because the page height is unchanged (the search bar just get overlayed). Would be cool to have a way to keep the modal centered even on mobile.
Expected Behavior
No response
Steps To Reproduce
What package is effected by this issue?
@web3-onboard/core
Is this a build or a runtime issue?
Runtime
Package Version
2.9.1-alpha.2
Node Version
No response
What browsers are you seeing the problem on?
No response
Relevant log output
No response
Anything else?
No response
Sanity Check
The text was updated successfully, but these errors were encountered: