You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While building a dapp using web-onboard we were unable to get walletconnect to work. Pedro from waleltconnect looked at the issue and also couldn't figure out why. I just stumbled upon the answer though.
However the walletconnect function would just hang after scanning the QR code on a mobile wallet. The function started working when I changed to either:
The myLogo variable is a large SVG string, about 50kB in size. Walletconnect works when one or the other is listed but not both. A smaller SVG can be listed in tandem with the larger one, but the app breaks when both are the large image. Maybe something with a memory limit?
Expected Behavior
I'd expect the app to work regardless of a logo and an icon being 50kB in size.
Steps To Reproduce
Tey configuring a wallet with logo and icon as the following 50kB svg (logo from https://folia.app):
If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.
The text was updated successfully, but these errors were encountered:
@okwme thanks for reporting this issue!
We pass both icon and logo to the WalletConnect constructor as seen here.
Ill double check with the team on size limits and pass this github issue along as well for context.
Thank you again for reporting and we will get this issue resolved.
Ah didn't realize it was a config for walletconnect under the hood!
thanks for forwarding to the team, i'm happy to open an issue there, should i proceed?
Current Behavior
While building a dapp using web-onboard we were unable to get walletconnect to work. Pedro from waleltconnect looked at the issue and also couldn't figure out why. I just stumbled upon the answer though.
Previously our
appMetadata
looked like this:However the walletconnect function would just hang after scanning the QR code on a mobile wallet. The function started working when I changed to either:
or
The
myLogo
variable is a large SVG string, about 50kB in size. Walletconnect works when one or the other is listed but not both. A smaller SVG can be listed in tandem with the larger one, but the app breaks when both are the large image. Maybe something with a memory limit?Expected Behavior
I'd expect the app to work regardless of a logo and an icon being 50kB in size.
Steps To Reproduce
Tey configuring a wallet with logo and icon as the following 50kB svg (logo from https://folia.app):
What package is effected by this issue?
@web3-onboard/walletconnect
Is this a build or a runtime issue?
Runtime
Package Version
2.20.4
Node Version
16.19
What browsers are you seeing the problem on?
Chrome
Relevant log output
No response
Anything else?
No response
Sanity Check
The text was updated successfully, but these errors were encountered: