Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a PR to Giveth project #1879

Open
maikReal opened this issue May 2, 2024 · 3 comments
Open

Make a PR to Giveth project #1879

maikReal opened this issue May 2, 2024 · 3 comments
Assignees
@maxaleks @maikReal
Labels
PM review For issues what are needed to be reviewed by PM

Comments

@maikReal
Copy link
Collaborator

maikReal commented May 2, 2024 •
edited
Loading

What to do?

We need to make PRs to all Giveth repos where we would change Etherscan links to Blockscout

There are 3 projects that they have:

Here is the contribution guide: https://docs.giveth.io/dapps/contributors/

The list of repos:
@maxaleks
Copy link
Contributor

@maxaleks maxaleks added the PM review For issues what are needed to be reviewed by PM label May 27, 2024
@maikReal
Copy link
Collaborator Author

Seems the Giveth team won't merge our PR. Closing the issue

@maikReal maikReal reopened this Nov 29, 2024
@maikReal
Copy link
Collaborator Author

@maxaleks can you pls check the PR that you made previously to giveth. We need to resolve conflicts there
Giveth/giveth-dapps-v2#4206 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxaleks maxaleks

@maikReal maikReal

Labels
PM review For issues what are needed to be reviewed by PM
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxaleks @maikReal