From c061409d2b8d00aebbd6937a0da22b333076b421 Mon Sep 17 00:00:00 2001 From: Nishant Date: Wed, 15 Jan 2025 20:49:51 -0500 Subject: [PATCH 01/19] Update rmqperftest_runner.cpp Signed-off-by: Nishant --- examples/rmqperftest/rmqperftest_runner.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/rmqperftest/rmqperftest_runner.cpp b/examples/rmqperftest/rmqperftest_runner.cpp index 9ef89dd..951e92f 100644 --- a/examples/rmqperftest/rmqperftest_runner.cpp +++ b/examples/rmqperftest/rmqperftest_runner.cpp @@ -86,7 +86,7 @@ class ConfirmCallback { void operator()(const rmqt::Message&, const bsl::string&, - const rmqt::ConfirmResponse&){}; + const rmqt::ConfirmResponse&) {}; }; bsl::string_view queueNameOrRoutingKey(bsl::string_view routingKey, From 44874c6bc902eafd94093960036fbfe28983cc71 Mon Sep 17 00:00:00 2001 From: Nishant Date: Wed, 15 Jan 2025 20:50:58 -0500 Subject: [PATCH 02/19] Update rmqa_rabbitcontext.cpp Signed-off-by: Nishant --- src/rmq/rmqa/rmqa_rabbitcontext.cpp | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/rmq/rmqa/rmqa_rabbitcontext.cpp b/src/rmq/rmqa/rmqa_rabbitcontext.cpp index 8568378..441a2a3 100644 --- a/src/rmq/rmqa/rmqa_rabbitcontext.cpp +++ b/src/rmq/rmqa/rmqa_rabbitcontext.cpp @@ -60,6 +60,19 @@ bsl::shared_ptr RabbitContext::createVHostConnection( .managedPtr())); } +bsl::shared_ptr RabbitContext::createVHostConnection( + const bsl::string& userDefinedName, + const bsl::shared_ptr& endpoint, + const bsl::shared_ptr& credentials, + const rmqt::ErrorCallback& errorCallback) +{ + return bsl::shared_ptr( + new VHost(d_impl + ->createVHostConnection( + userDefinedName, endpoint, credentials, errorCallback) + .managedPtr())); +} + bsl::shared_ptr RabbitContext::createVHostConnection(const bsl::string& userDefinedName, const rmqt::VHostInfo& vhostInfo) From 20ec47753ae0a51449cc03237661ffe40f6d5b26 Mon Sep 17 00:00:00 2001 From: Nishant Date: Wed, 15 Jan 2025 20:51:53 -0500 Subject: [PATCH 03/19] Update rmqa_rabbitcontext.h Signed-off-by: Nishant --- src/rmq/rmqa/rmqa_rabbitcontext.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/rmq/rmqa/rmqa_rabbitcontext.h b/src/rmq/rmqa/rmqa_rabbitcontext.h index 33a0e84..c987132 100644 --- a/src/rmq/rmqa/rmqa_rabbitcontext.h +++ b/src/rmq/rmqa/rmqa_rabbitcontext.h @@ -80,6 +80,12 @@ class RabbitContext { const bsl::shared_ptr& endpoint, const bsl::shared_ptr& credentials); + bsl::shared_ptr + createVHostConnection(const bsl::string& userDefinedName, + const bsl::shared_ptr& endpoint, + const bsl::shared_ptr& credentials, + const rmqt::ErrorCallback& errorCallback); + /// \brief Connect to a RabbitMQ broker /// /// \param vhostInfo identifies the broker to connect to & authentication From b7a294e5a5e5ff8025c5c3e4fe6a84a1c7a1306b Mon Sep 17 00:00:00 2001 From: Nishant Date: Wed, 15 Jan 2025 20:52:53 -0500 Subject: [PATCH 04/19] Update rmqa_rabbitcontextimpl.cpp Signed-off-by: Nishant --- src/rmq/rmqa/rmqa_rabbitcontextimpl.cpp | 26 +++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/src/rmq/rmqa/rmqa_rabbitcontextimpl.cpp b/src/rmq/rmqa/rmqa_rabbitcontextimpl.cpp index aa918dd..19aaed0 100644 --- a/src/rmq/rmqa/rmqa_rabbitcontextimpl.cpp +++ b/src/rmq/rmqa/rmqa_rabbitcontextimpl.cpp @@ -168,7 +168,6 @@ RabbitContextImpl::RabbitContextImpl( d_eventLoop->resolver( options.shuffleConnectionEndpoints().value_or(false)), d_eventLoop->timerFactory(), - d_onError, metricPublisher, d_connectionMonitor, options.clientProperties(), @@ -281,6 +280,29 @@ bsl::shared_ptr RabbitContextImpl::createVHostConnection( bdlf::PlaceHolders::_1)); } +bsl::shared_ptr RabbitContextImpl::createVHostConnection( + const bsl::string& userDefinedName, + const bsl::shared_ptr& endpoint, + const bsl::shared_ptr& credentials, + const rmqt::ErrorCallback& errorCallback) +{ + // Override the error callback provided in RabbitContext + // by a per vhost error callback + d_onError = bdlf::BindUtil::bind(&handleErrorCbOnEventLoop, + bsl::ref(d_threadPool), + errorCallback, + bdlf::PlaceHolders::_1, + bdlf::PlaceHolders::_2); + + return bsl::make_shared( + bdlf::BindUtil::bind(&RabbitContextImpl::createNewConnection, + this, + userDefinedName, + endpoint, + credentials, + bdlf::PlaceHolders::_1)); +} + bsl::shared_ptr RabbitContextImpl::createVHostConnection(const bsl::string& userDefinedName, const rmqt::VHostInfo& vhostInfo) @@ -333,7 +355,7 @@ rmqt::Future RabbitContextImpl::createNewConnection( } bsl::shared_ptr amqpConn = - d_connectionFactory->create(endpoint, credentials, name); + d_connectionFactory->create(endpoint, credentials, d_onError, name); // The cancel function is given `amqpConn` which is what keeps it alive // until the shared_ptr is retrieved in From 8a7e0f5de8caf7852a2de7f8d9102ae63a63e022 Mon Sep 17 00:00:00 2001 From: Nishant Date: Wed, 15 Jan 2025 20:53:30 -0500 Subject: [PATCH 05/19] Update rmqa_rabbitcontextimpl.h Signed-off-by: Nishant --- src/rmq/rmqa/rmqa_rabbitcontextimpl.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/rmq/rmqa/rmqa_rabbitcontextimpl.h b/src/rmq/rmqa/rmqa_rabbitcontextimpl.h index f9271be..1b2babc 100644 --- a/src/rmq/rmqa/rmqa_rabbitcontextimpl.h +++ b/src/rmq/rmqa/rmqa_rabbitcontextimpl.h @@ -54,6 +54,12 @@ class RabbitContextImpl : public rmqp::RabbitContext { const bsl::shared_ptr& credentials) BSLS_KEYWORD_OVERRIDE; + bsl::shared_ptr createVHostConnection( + const bsl::string& userDefinedName, + const bsl::shared_ptr& endpoint, + const bsl::shared_ptr& credentials, + const rmqt::ErrorCallback& errorCallback) BSLS_KEYWORD_OVERRIDE; + bsl::shared_ptr createVHostConnection( const bsl::string& userDefinedName, const rmqt::VHostInfo& endpoint) BSLS_KEYWORD_OVERRIDE; From e558dc76d064d70948a0ebb42896ba8ceeccb77d Mon Sep 17 00:00:00 2001 From: Nishant Date: Wed, 15 Jan 2025 20:53:50 -0500 Subject: [PATCH 06/19] Update rmqamqp_channelfactory.h Signed-off-by: Nishant --- src/rmq/rmqamqp/rmqamqp_channelfactory.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rmq/rmqamqp/rmqamqp_channelfactory.h b/src/rmq/rmqamqp/rmqamqp_channelfactory.h index 49a2358..d0ea3ed 100644 --- a/src/rmq/rmqamqp/rmqamqp_channelfactory.h +++ b/src/rmq/rmqamqp/rmqamqp_channelfactory.h @@ -36,7 +36,7 @@ namespace rmqamqp { class ChannelFactory { public: - virtual ~ChannelFactory(){}; + virtual ~ChannelFactory() {}; virtual bsl::shared_ptr createReceiveChannel( const rmqt::Topology& topology, From cb98c3c69758e2e330fe4971bcdfd00596bf7d71 Mon Sep 17 00:00:00 2001 From: Nishant Date: Wed, 15 Jan 2025 20:56:33 -0500 Subject: [PATCH 07/19] Update rmqamqp_connection.cpp Signed-off-by: Nishant --- src/rmq/rmqamqp/rmqamqp_connection.cpp | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/rmq/rmqamqp/rmqamqp_connection.cpp b/src/rmq/rmqamqp/rmqamqp_connection.cpp index b13efcd..d962141 100644 --- a/src/rmq/rmqamqp/rmqamqp_connection.cpp +++ b/src/rmq/rmqamqp/rmqamqp_connection.cpp @@ -983,13 +983,11 @@ bsl::string Connection::connectionDebugName() const Connection::Factory::Factory( const bsl::shared_ptr& resolver, const bsl::shared_ptr& timerFactory, - const rmqt::ErrorCallback& errorCb, const bsl::shared_ptr& metricPublisher, const bsl::shared_ptr& connectionMonitor, const rmqt::FieldTable& clientProperties, const bsl::optional& connectionErrorThreshold) -: d_errorCb(errorCb) -, d_clientProperties(clientProperties) +: d_clientProperties(clientProperties) , d_metricPublisher(metricPublisher) , d_resolver(resolver) , d_timerFactory(timerFactory) @@ -1001,11 +999,12 @@ Connection::Factory::Factory( bsl::shared_ptr Connection::Factory::create( const bsl::shared_ptr& endpoint, const bsl::shared_ptr& credentials, + const rmqt::ErrorCallback& errorCallback, const bsl::string& name) { bsl::shared_ptr result(new rmqamqp::Connection( d_resolver, - newRetryHandler(), + newRetryHandler(errorCallback), newHeartBeatManager(), d_timerFactory, newChannelFactory(), @@ -1020,18 +1019,19 @@ bsl::shared_ptr Connection::Factory::create( return result; } -bsl::shared_ptr Connection::Factory::newRetryHandler() +bsl::shared_ptr +Connection::Factory::newRetryHandler(const rmqt::ErrorCallback& errorCallback) { return d_connectionErrorThreshold ? bsl::shared_ptr( bsl::make_shared( d_timerFactory, - d_errorCb, + errorCallback, bsl::make_shared(), *d_connectionErrorThreshold)) : bsl::make_shared( d_timerFactory, - d_errorCb, + errorCallback, bsl::make_shared()); } From 2d02c2f3d719d53ce3371908e205401c142a4012 Mon Sep 17 00:00:00 2001 From: Nishant Date: Wed, 15 Jan 2025 20:57:46 -0500 Subject: [PATCH 08/19] Update rmqamqp_connection.h Signed-off-by: Nishant --- src/rmq/rmqamqp/rmqamqp_connection.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/rmq/rmqamqp/rmqamqp_connection.h b/src/rmq/rmqamqp/rmqamqp_connection.h index 49d84e6..56ce901 100644 --- a/src/rmq/rmqamqp/rmqamqp_connection.h +++ b/src/rmq/rmqamqp/rmqamqp_connection.h @@ -310,7 +310,6 @@ class Connection::Factory { Factory(const bsl::shared_ptr& resolver, const bsl::shared_ptr& timerFactory, - const rmqt::ErrorCallback& errorCb, const bsl::shared_ptr& metricPublisher, const bsl::shared_ptr& connectionMonitor, const rmqt::FieldTable& clientProperties, @@ -321,10 +320,12 @@ class Connection::Factory { virtual bsl::shared_ptr create(const bsl::shared_ptr& endpoint, const bsl::shared_ptr& credentials, + const rmqt::ErrorCallback& errorCallback, const bsl::string& name = ""); protected: - virtual bsl::shared_ptr newRetryHandler(); + virtual bsl::shared_ptr + newRetryHandler(const rmqt::ErrorCallback& errorCallback); virtual bsl::shared_ptr newHeartBeatManager(); virtual bsl::shared_ptr newChannelFactory(); @@ -332,7 +333,6 @@ class Connection::Factory { Factory(const Factory&) BSLS_KEYWORD_DELETED; Factory& operator=(const Factory&) BSLS_KEYWORD_DELETED; - const rmqt::ErrorCallback d_errorCb; const rmqt::FieldTable d_clientProperties; const bsl::shared_ptr d_metricPublisher; const bsl::shared_ptr d_resolver; From 12b511cac47d8175faeec829d1eb144d18963aab Mon Sep 17 00:00:00 2001 From: Nishant Date: Wed, 15 Jan 2025 20:58:08 -0500 Subject: [PATCH 09/19] Update rmqio_timer.h Signed-off-by: Nishant --- src/rmq/rmqio/rmqio_timer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rmq/rmqio/rmqio_timer.h b/src/rmq/rmqio/rmqio_timer.h index f31e795..327db63 100644 --- a/src/rmq/rmqio/rmqio_timer.h +++ b/src/rmq/rmqio/rmqio_timer.h @@ -72,7 +72,7 @@ class Timer { class TimerFactory { public: - virtual ~TimerFactory(){}; + virtual ~TimerFactory() {}; /// Creates a timer and initializes its timeout. The timer should be /// started by calling start(). From 7d83a179ef727c2d6747fbc9470f5ecdc6dfaf7d Mon Sep 17 00:00:00 2001 From: Nishant Date: Wed, 15 Jan 2025 20:58:57 -0500 Subject: [PATCH 10/19] Update rmqp_rabbitcontext.h Signed-off-by: Nishant --- src/rmq/rmqp/rmqp_rabbitcontext.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/rmq/rmqp/rmqp_rabbitcontext.h b/src/rmq/rmqp/rmqp_rabbitcontext.h index 8820dc7..c83f2ac 100644 --- a/src/rmq/rmqp/rmqp_rabbitcontext.h +++ b/src/rmq/rmqp/rmqp_rabbitcontext.h @@ -55,6 +55,12 @@ class RabbitContext { const bsl::shared_ptr& endpoint, const bsl::shared_ptr& credentials) = 0; + virtual bsl::shared_ptr + createVHostConnection(const bsl::string& userDefinedName, + const bsl::shared_ptr& endpoint, + const bsl::shared_ptr& credentials, + const rmqt::ErrorCallback& errorCallback) = 0; + /// \brief Connect to a RabbitMQ broker /// /// \param vhostInfo identifies the broker to connect to & authentication From 2f62fbf03488460ded776a524531883b72661725 Mon Sep 17 00:00:00 2001 From: Nishant Date: Wed, 15 Jan 2025 20:59:15 -0500 Subject: [PATCH 11/19] Update rmqt_credentials.h Signed-off-by: Nishant --- src/rmq/rmqt/rmqt_credentials.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rmq/rmqt/rmqt_credentials.h b/src/rmq/rmqt/rmqt_credentials.h index a736c70..346f3d5 100644 --- a/src/rmq/rmqt/rmqt_credentials.h +++ b/src/rmq/rmqt/rmqt_credentials.h @@ -25,7 +25,7 @@ namespace rmqt { class Credentials { public: - virtual ~Credentials(){}; + virtual ~Credentials() {}; virtual bsl::string formatCredentials() = 0; virtual bsl::string authenticationMechanism() = 0; }; From 5a8821493f6e5517d2cabb1c5c8c215623ba46b5 Mon Sep 17 00:00:00 2001 From: Nishant Date: Wed, 15 Jan 2025 20:59:30 -0500 Subject: [PATCH 12/19] Update rmqt_endpoint.h Signed-off-by: Nishant --- src/rmq/rmqt/rmqt_endpoint.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rmq/rmqt/rmqt_endpoint.h b/src/rmq/rmqt/rmqt_endpoint.h index dbc13ef..7705273 100644 --- a/src/rmq/rmqt/rmqt_endpoint.h +++ b/src/rmq/rmqt/rmqt_endpoint.h @@ -29,7 +29,7 @@ class SecurityParameters; class Endpoint { public: - virtual ~Endpoint(){}; + virtual ~Endpoint() {}; virtual bsl::string formatAddress() const = 0; virtual bsl::string hostname() const = 0; virtual bsl::string vhost() const = 0; From e20c21584db9ec4f0c7cbc4faffebb50123baac6 Mon Sep 17 00:00:00 2001 From: Nishant Date: Wed, 15 Jan 2025 21:00:10 -0500 Subject: [PATCH 13/19] Update rmqtestmocks_mockrabbitcontext.h Signed-off-by: Nishant --- src/rmqtestmocks/rmqtestmocks_mockrabbitcontext.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/rmqtestmocks/rmqtestmocks_mockrabbitcontext.h b/src/rmqtestmocks/rmqtestmocks_mockrabbitcontext.h index 3e1e778..6b734e8 100644 --- a/src/rmqtestmocks/rmqtestmocks_mockrabbitcontext.h +++ b/src/rmqtestmocks/rmqtestmocks_mockrabbitcontext.h @@ -54,6 +54,13 @@ class MockRabbitContext : public rmqp::RabbitContext { const bsl::shared_ptr& endpoint, const bsl::shared_ptr& credentials)); + MOCK_METHOD4(createVHostConnection, + bsl::shared_ptr( + const bsl::string& userDefinedName, + const bsl::shared_ptr& endpoint, + const bsl::shared_ptr& credentials, + const rmqt::ErrorCallback& errorCallback)); + MOCK_METHOD2( createVHostConnection, bsl::shared_ptr(const bsl::string& userDefinedName, From 49845a85852a280b1f8351244703ef98cc266a7e Mon Sep 17 00:00:00 2001 From: Nishant Date: Wed, 15 Jan 2025 21:01:24 -0500 Subject: [PATCH 14/19] Update rmqamqp_connection.t.cpp Signed-off-by: Nishant --- src/tests/rmqamqp/rmqamqp_connection.t.cpp | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/tests/rmqamqp/rmqamqp_connection.t.cpp b/src/tests/rmqamqp/rmqamqp_connection.t.cpp index 2c99b0b..2a465a6 100644 --- a/src/tests/rmqamqp/rmqamqp_connection.t.cpp +++ b/src/tests/rmqamqp/rmqamqp_connection.t.cpp @@ -322,7 +322,6 @@ class ConnectionFactory : public rmqamqp::Connection::Factory { ConnectionFactory( const bsl::shared_ptr& resolver, const bsl::shared_ptr& timerFactory, - const rmqt::ErrorCallback& errorCb, const bsl::shared_ptr& metricPublisher, const rmqt::FieldTable& clientProperties, const bsl::shared_ptr& retryHandler, @@ -330,7 +329,6 @@ class ConnectionFactory : public rmqamqp::Connection::Factory { const bsl::shared_ptr& channelFactory) : rmqamqp::Connection::Factory(resolver, timerFactory, - errorCb, metricPublisher, bsl::make_shared(), clientProperties, @@ -340,7 +338,8 @@ class ConnectionFactory : public rmqamqp::Connection::Factory { , d_channelFactory(channelFactory) { } - bsl::shared_ptr newRetryHandler() BSLS_KEYWORD_OVERRIDE + bsl::shared_ptr newRetryHandler( + const rmqt::ErrorCallback& errorCallback) BSLS_KEYWORD_OVERRIDE { return d_retryHandler; } @@ -406,7 +405,6 @@ class ConnectionTests : public ::testing::Test { , d_clientProperties(generateDefaultClientProperties()) , d_factory(bsl::make_shared(d_resolver, d_timerFactory, - d_errorCallback, d_metricPublisher, d_clientProperties, d_retryHandler, @@ -636,7 +634,7 @@ class ConnectionTests : public ::testing::Test { createAndStartConnection(const bsl::string& name = "test-connection") { bsl::shared_ptr conn = - d_factory->create(d_endpoint, d_credentials, name); + d_factory->create(d_endpoint, d_credentials, d_errorCallback, name); conn->startFirstConnection(d_onConnectCb); return conn; @@ -683,7 +681,6 @@ TEST_F(ConnectionTests, ClientProperties) rmqt::FieldValue(bsl::string("BAR")); // Add one more d_factory = bsl::make_shared(d_resolver, d_timerFactory, - d_errorCallback, d_metricPublisher, overriddenClientProperties, d_retryHandler, @@ -721,7 +718,6 @@ TEST_F(ConnectionTests, ClientPropertiesCantOverrideReservedOnes) bsl::string("Should get overriden by library")); // Add one more d_factory = bsl::make_shared(d_resolver, d_timerFactory, - d_errorCallback, d_metricPublisher, overriddenClientProperties, d_retryHandler, From 65467bdfc510fda58da8236f3e69a6ce2513299b Mon Sep 17 00:00:00 2001 From: Nishant Date: Wed, 15 Jan 2025 21:27:37 -0500 Subject: [PATCH 15/19] Update rmqperftest_runner.cpp Signed-off-by: Nishant --- examples/rmqperftest/rmqperftest_runner.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/rmqperftest/rmqperftest_runner.cpp b/examples/rmqperftest/rmqperftest_runner.cpp index 951e92f..9ef89dd 100644 --- a/examples/rmqperftest/rmqperftest_runner.cpp +++ b/examples/rmqperftest/rmqperftest_runner.cpp @@ -86,7 +86,7 @@ class ConfirmCallback { void operator()(const rmqt::Message&, const bsl::string&, - const rmqt::ConfirmResponse&) {}; + const rmqt::ConfirmResponse&){}; }; bsl::string_view queueNameOrRoutingKey(bsl::string_view routingKey, From bd8a16f73d940aa6147d9cd9d4cf3182634d075f Mon Sep 17 00:00:00 2001 From: Nishant Date: Wed, 15 Jan 2025 21:27:59 -0500 Subject: [PATCH 16/19] Update rmqamqp_channelfactory.h Signed-off-by: Nishant --- src/rmq/rmqamqp/rmqamqp_channelfactory.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rmq/rmqamqp/rmqamqp_channelfactory.h b/src/rmq/rmqamqp/rmqamqp_channelfactory.h index d0ea3ed..49a2358 100644 --- a/src/rmq/rmqamqp/rmqamqp_channelfactory.h +++ b/src/rmq/rmqamqp/rmqamqp_channelfactory.h @@ -36,7 +36,7 @@ namespace rmqamqp { class ChannelFactory { public: - virtual ~ChannelFactory() {}; + virtual ~ChannelFactory(){}; virtual bsl::shared_ptr createReceiveChannel( const rmqt::Topology& topology, From c1b012288d1b340ed8863b58fbf3f25c948cca38 Mon Sep 17 00:00:00 2001 From: Nishant Date: Wed, 15 Jan 2025 21:36:39 -0500 Subject: [PATCH 17/19] Update rmqt_endpoint.h Signed-off-by: Nishant --- src/rmq/rmqt/rmqt_endpoint.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rmq/rmqt/rmqt_endpoint.h b/src/rmq/rmqt/rmqt_endpoint.h index 7705273..dbc13ef 100644 --- a/src/rmq/rmqt/rmqt_endpoint.h +++ b/src/rmq/rmqt/rmqt_endpoint.h @@ -29,7 +29,7 @@ class SecurityParameters; class Endpoint { public: - virtual ~Endpoint() {}; + virtual ~Endpoint(){}; virtual bsl::string formatAddress() const = 0; virtual bsl::string hostname() const = 0; virtual bsl::string vhost() const = 0; From 9782bd1235cc435da4cb6a3c0ebf891dc5dca2b6 Mon Sep 17 00:00:00 2001 From: Nishant Date: Wed, 15 Jan 2025 21:36:49 -0500 Subject: [PATCH 18/19] Update rmqt_credentials.h Signed-off-by: Nishant --- src/rmq/rmqt/rmqt_credentials.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rmq/rmqt/rmqt_credentials.h b/src/rmq/rmqt/rmqt_credentials.h index 346f3d5..a736c70 100644 --- a/src/rmq/rmqt/rmqt_credentials.h +++ b/src/rmq/rmqt/rmqt_credentials.h @@ -25,7 +25,7 @@ namespace rmqt { class Credentials { public: - virtual ~Credentials() {}; + virtual ~Credentials(){}; virtual bsl::string formatCredentials() = 0; virtual bsl::string authenticationMechanism() = 0; }; From 2161d81b8738f37e46328a796c3a002178e1e009 Mon Sep 17 00:00:00 2001 From: Nishant Date: Wed, 15 Jan 2025 21:37:07 -0500 Subject: [PATCH 19/19] Update rmqio_timer.h Signed-off-by: Nishant --- src/rmq/rmqio/rmqio_timer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rmq/rmqio/rmqio_timer.h b/src/rmq/rmqio/rmqio_timer.h index 327db63..f31e795 100644 --- a/src/rmq/rmqio/rmqio_timer.h +++ b/src/rmq/rmqio/rmqio_timer.h @@ -72,7 +72,7 @@ class Timer { class TimerFactory { public: - virtual ~TimerFactory() {}; + virtual ~TimerFactory(){}; /// Creates a timer and initializes its timeout. The timer should be /// started by calling start().