Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for diffing the new Xcode 16 project elements #140

Open
kwridan opened this issue Dec 12, 2024 · 0 comments · May be fixed by #143
Open

Add support for diffing the new Xcode 16 project elements #140

kwridan opened this issue Dec 12, 2024 · 0 comments · May be fixed by #143

Comments

@kwridan
Copy link
Contributor

kwridan commented Dec 12, 2024

Is your feature request related to a problem? Please describe.

Xcode 16 introduces a few new elements for project files and groups (e.g. PBXFileSystemSynchronizedRootGroup) which are currently ignored by xcdiff.

Describe the solution you'd like

  • Update xcdiff to account for those new elements in the project diff
  • Add new Xcode 16 fixtures that utilise those new elements to aid developing and testing this

Additional context

kwridan added a commit to kwridan/xcdiff that referenced this issue Feb 12, 2025
Resolves: bloomberg#140

- Adding a new comparator to diff the Xcode 16 synchronized groups which can include sources

Test Plan:

Run xcdiff on the new fixture and verify it flags diffs for the mismatching groups

```
swift run xcdiff -p1 Fixtures/xcode16_syncgroups_1/Project.xcodeproj -p2 Fixtures/xcode16_syncgroups_2/Project.xcodeproj -v
```

Signed-off-by: Kassem Wridan <[email protected]>
kwridan added a commit to kwridan/xcdiff that referenced this issue Feb 12, 2025
Resolves: bloomberg#140

- Adding a new comparator to diff the Xcode 16 synchronized groups which can include sources

Test Plan:

Run xcdiff on the new fixture and verify it flags diffs for the mismatching groups

```
swift run xcdiff -p1 Fixtures/xcode16_syncgroups_1/Project.xcodeproj -p2 Fixtures/xcode16_syncgroups_2/Project.xcodeproj -v
```

Signed-off-by: Kassem Wridan <[email protected]>
@kwridan kwridan linked a pull request Feb 12, 2025 that will close this issue
kwridan added a commit to kwridan/xcdiff that referenced this issue Feb 12, 2025
Resolves: bloomberg#140

- Adding a new comparator to diff the Xcode 16 synchronized groups which can include sources

Test Plan:

Run xcdiff on the new fixture and verify it flags diffs for the mismatching groups

```
swift run xcdiff -p1 Fixtures/xcode16_syncgroups_1/Project.xcodeproj -p2 Fixtures/xcode16_syncgroups_2/Project.xcodeproj -v
```

Signed-off-by: Kassem Wridan <[email protected]>
kwridan added a commit to kwridan/xcdiff that referenced this issue Feb 12, 2025
Resolves: bloomberg#140

- Adding a new comparator to diff the Xcode 16 synchronized groups which can include sources

Test Plan:

Run xcdiff on the new fixture and verify it flags diffs for the mismatching groups

```
swift run xcdiff -p1 Fixtures/xcode16_syncgroups_1/Project.xcodeproj -p2 Fixtures/xcode16_syncgroups_2/Project.xcodeproj -v
```

Signed-off-by: Kassem Wridan <[email protected]>
kwridan added a commit to kwridan/xcdiff that referenced this issue Feb 12, 2025
Resolves: bloomberg#140

- Adding a new comparator to diff the Xcode 16 synchronized groups which can include sources

Test Plan:

Run xcdiff on the new fixture and verify it flags diffs for the mismatching groups

```
swift run xcdiff -p1 Fixtures/xcode16_syncgroups_1/Project.xcodeproj -p2 Fixtures/xcode16_syncgroups_2/Project.xcodeproj -v
```

Signed-off-by: Kassem Wridan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant