Add File system synchronized groups comparator #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwridan
force-pushed
the
feature/syncgroup-comparator
branch
from
b7be346 to
e6779d7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
==========================================
- Coverage 97.05% 97.02% -0.03%
==========================================
Files 52 53 +1
Lines 2986 3024 +38
==========================================
+ Hits 2898 2934 +36
- Misses 88 90 +2 ☔ View full report in Codecov by Sentry. |
kwridan
force-pushed
the
feature/syncgroup-comparator
branch
from
e6779d7 to
598e7df
Compare
Resolves: bloomberg#140 - Adding a new comparator to diff the Xcode 16 synchronized groups which can include sources Test Plan: Run xcdiff on the new fixture and verify it flags diffs for the mismatching groups ``` swift run xcdiff -p1 Fixtures/xcode16_syncgroups_1/Project.xcodeproj -p2 Fixtures/xcode16_syncgroups_2/Project.xcodeproj -v ``` Signed-off-by: Kassem Wridan <[email protected]>
kwridan
force-pushed
the
feature/syncgroup-comparator
branch
from
598e7df to
022f745
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #140
Describe your changes
Testing performed
Run xcdiff on the new fixture and verify it flags diffs for the mismatching groups