-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUESTS] - post here for suggestions/feature requests #6
Comments
Hi Jim, |
Is there/could there be a method to output unassigned reads into a file as an output? |
Hi @astrovsky01, This is unfortunately not possible due to the way sylph works. It doesn't classify each read. It operates on the ensemble of reads. This means it can not output unassigned reads, only estimate the percentage of. |
@bluenote-1577 I'm not sure how the backend algorithm works but is it possible to add |
@jolespin Hi Josh, unfortunately this isn't possible. This is because skani actually tries to get a pseudo-ish alignment, by sylph doesn't do anything like that. I agree it would be very nice if it were possible though... |
Ok that's good to know! Would finding the overlap in kmers do the trick or is it way more complicated than that? |
Also one more question, does sylph allow for outputting abundance instead of relative abundance? |
@jolespin sorry for the late response:
|
I can imagine that is quite complicated. Themisto just popped up on my radar so I'm going to give this a try soon.
Is the
I'm mostly curious on how some of my compositionally valid network analysis (https://github.com/jolespin/ensemble_networkx) differs between coverage normalized and unnormalized data but definitely not a critical assessment. Just a bit of curiosity. |
I'm looking at the docs now and not sure which field indicates the % of reads/k-mers not aligned/overlapping(sorry if that's the wrong term) with the k-mers in the database/sketch. If this isn't currently available, would it be possible to add this metric? It would greatly benefit my workflow when determining whether or not I want to assemble/bin genomes from a metagenomic assembly. |
You'll notice that the "Sequence abundance" column doesn't sum to 100% if the So without Species 1 50% But with Species 1 5% let me know if that makes sense. I didn't want to add a new column because it doesn't really make sense... but this is a bit non-obvious to see |
Excellent! Love that functionality. So essentially, I can just run |
@jolespin yes exactly. BTW, I discovered the "discussion" feature in github. I think we can migrate the questions there, as well as suggestions, perhaps keeping this thread for specific feature requests. |
@jolespin I've added the ability to inspect sylph databases/sketches in v0.7.0. Not on conda yet, but on github and the binary. |
Feature requests
Purpose: this is a place to easily log suggestions/feature requests. E.g:
Give a rationale and provide concise/clear instructions if possible. Opinions are welcome too.
You're welcome to email me or open another issue. This thread is to aggregate suggestions without the hassle of opening another issue.
Current feature requests
Here are some current feature requests.
Originally posted by @jolespin in bluenote-1577/skani#23 (comment)
Option for renaming samples. Sylph currently fixes each sample sketch to the read names. `done in v0.5.0Command line options for inspecting database sketches.done in v0.7.0Line-delimited file for database sketches fordone in v0.5.0sylph profile/query
@fplaza #6 (comment)
Save read length while sketching so the user does not have to provide it to compute true coverage.done in v0.5.0#7
The text was updated successfully, but these errors were encountered: