Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The QtRemoteDispatcher class had an outdated name for one of the objects inside the dispatcher it was creating, which caused the entire class to crash when used. Fixing the name (
_bluesky_consumer.consumer
->_bluesky_consumer._consumer
) restores functionality.See the code in https://github.com/bluesky/bluesky-kafka/blob/main/bluesky_kafka/__init__.py#L149 and bluesky/bluesky-kafka@e9001b7 which changed from
consumer
to_consumer
How Has This Been Tested?
Tested with a containerized beamline running Kafka. Confirmed that QtRemoteDispatcher now instantiates correctly, and dispatches correctly.