Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a label for each reflection #293

Open
prjemian opened this issue Nov 9, 2023 · 3 comments
Open

Add a label for each reflection #293

prjemian opened this issue Nov 9, 2023 · 3 comments
Assignees
Labels
Milestone

Comments

@prjemian
Copy link
Contributor

prjemian commented Nov 9, 2023

Let's implement reflection labels in a branch from 289-restore-reflections.

Originally posted by @prjemian in #292 (comment)

@prjemian prjemian added this to the v1.1 milestone Nov 9, 2023
@prjemian prjemian self-assigned this Nov 9, 2023
@prjemian
Copy link
Contributor Author

prjemian commented Nov 9, 2023

Reflections are used/described in these files (and related tests):

file number of instances of reflection text
configuration.py 40
diffract.py 20
sample.py 94
user.py 18
util.py 19

@prjemian
Copy link
Contributor Author

prjemian commented Nov 9, 2023

This is not a trivial change to make. Due to the way reflections are handled now (libhkl keeps the defining list in its C memory), this could become a breaking change.

@prjemian
Copy link
Contributor Author

prjemian commented Nov 9, 2023

Changing priority and milestone for this issue.

@prjemian prjemian modified the milestones: v1.1, v2.0 Nov 9, 2023
@prjemian prjemian added the hklpy2 For hklpy2 label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant