Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron - quick options don't work correctly in preview #101

Closed
desplesda opened this issue Sep 18, 2019 · 6 comments
Closed

electron - quick options don't work correctly in preview #101

desplesda opened this issue Sep 18, 2019 · 6 comments
Labels
bug Something isn't working

Comments

@desplesda
Copy link
Collaborator

Issue by Subliminalman
Tuesday Aug 27, 2019 at 00:27 GMT
Originally opened as InfiniteAmmoInc/Yarn#101


For the preview mode within the electron yarn app (version 0.3.6) on OSx (haven't tried other platforms yet) it doesn't handle quick selections correctly. It will display the options but when it won't show the result. Rather it will hang on the selection, not show the result, then you have to select from the options again then it will go further into the script.

Here is the script I was testing with.

This is a test for writing

->Heya
    Howdy
->Heeeeya
    Wow
->Bye
    Goodbye

Meowdy
[[Barkdy|Bark]]
[[Meowdy|Meowdy]]

Here is the result from the script above.

Screen Shot 2019-08-26 at 6 25 28 PM

The expected result would be

This is a test for writing
[select Heeeeya]
Howdy
Wow

@desplesda
Copy link
Collaborator Author

Comment by blurymind
Tuesday Aug 27, 2019 at 05:27 GMT


This is a known bondagejs bug that keeps getting filed here. I might try to
make a fix for bondagejs and update the library in yarn at some point

On Tue, Aug 27, 2019, 3:27 AM Ryan [email protected] wrote:

For the preview mode within the electron yarn app (version 0.3.6) on OSx
(haven't tried other platforms yet) it doesn't handle quick selections
correctly. It will display the options but when it won't show the result.
Rather it will hang on the selection, not show the result, then you have to
select from the options again then it will go further into the script.

Here is the script I was testing with.

This is a test for writing

->Heya
Howdy
->Heeeeya
Wow
->Bye
Goodbye

Meowdy
[[Barkdy|Bark]]
[[Meowdy|Meowdy]]

Here is the result from the script above.

[image: Screen Shot 2019-08-26 at 6 25 28 PM]
https://user-images.githubusercontent.com/1288980/63731877-05edcf00-c82f-11e9-834d-c8abaa8d2465.png


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
InfiniteAmmoInc/Yarn#101,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABRRWVP7DSOIQ6L7OIDJW7LQGRYHHANCNFSM4IPY73ZQ
.

@blurymind
Copy link
Owner

blurymind commented Sep 18, 2019

I have disabled previewing temporarily. It's dependency on electron needs to be scrapped and the preview should be refactored to appear in the same window. The bug here needs to be addressed in bondagejs and I would suggest closing it. I no longer can close issues, so someone else will have to do it

@blurymind
Copy link
Owner

blurymind commented Sep 27, 2019

Btw they will work if you add a space between the -> and the lines

@blurymind
Copy link
Owner

blurymind commented Sep 27, 2019

do

This is a test for writing

-> Heya
    Howdy
-> Heeeeya
    Wow
-> Bye
    Goodbye

Meowdy
[[Barkdy|Bark]]
[[Meowdy|Meowdy]]

instead of

This is a test for writing

->Heya
    Howdy
->Heeeeya
    Wow
->Bye
    Goodbye

Meowdy
[[Barkdy|Bark]]
[[Meowdy|Meowdy]]

@desplesda
Copy link
Collaborator Author

+1 for "meowdy".

@FaultyFunctions
Copy link
Contributor

Related to #199. This one has been inactive for a while. Closing this one, but refer to the other issue for more information.

@FaultyFunctions FaultyFunctions added the bug Something isn't working label Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants