Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing window to narrow profile offsets connection lines #77

Closed
desplesda opened this issue Sep 18, 2019 · 9 comments
Closed

Resizing window to narrow profile offsets connection lines #77

desplesda opened this issue Sep 18, 2019 · 9 comments

Comments

@desplesda
Copy link
Collaborator

Issue by b-erv
Thursday Aug 09, 2018 at 18:36 GMT
Originally opened as InfiniteAmmoInc/Yarn#77


When the Yarn window is close to or at its minimum width, any lines between nodes get shunted to one side and no longer line up. Happening for me consistently at various resolutions and display magnification settings.
resize

@desplesda
Copy link
Collaborator Author

Comment by blurymind
Thursday Aug 09, 2018 at 20:26 GMT


Does that also happen in the electron version?

Also can you please zip the file you have open and attach it to your post
here

On Thu, Aug 9, 2018 at 7:36 PM b-erv notifications@github.com wrote:

When the Yarn window is close to or at its minimum width, any lines
between nodes get shunted to one side and no longer line up. Happening for
me consistently at various resolutions and display magnification settings.
[image: resize]
https://user-images.githubusercontent.com/17258819/43918439-15efe6d4-9be1-11e8-9d2a-435489c3c8b5.gif


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
InfiniteAmmoInc/Yarn#77, or mute the thread
https://github.com/notifications/unsubscribe-auth/AGMbVdfrDeam8R68HCTqW0vHLJVPDXPnks5uPIEwgaJpZM4V2M8W
.

@desplesda
Copy link
Collaborator Author

Comment by b-erv
Friday Aug 10, 2018 at 21:35 GMT


Yes, the same behaviour is occurring for me across versions. Additionally, it happens the same way with all .yarn files, even newly-created ones. Such as here:
demo.yarn.txt

@desplesda
Copy link
Collaborator Author

Comment by julsam
Saturday Aug 11, 2018 at 06:37 GMT


I've been able to reproduce the issue with the NWjs build (aka master) but not with the electron build.

Maybe it has to do with this? Not sure.

/* --- MEDIA --- */

@media (max-width: 830px) {
	.app-search {
		position: relative;
		float: left;
	}
	.app-menu {
		position: relative;
		float: right;
		margin-top: 20px;
	}
}

@desplesda
Copy link
Collaborator Author

Comment by blurymind
Saturday Aug 11, 2018 at 09:49 GMT


for the electron build - if it aint broke - no need to fix it :) might cause some regression

@desplesda
Copy link
Collaborator Author

Comment by julsam
Saturday Aug 11, 2018 at 09:59 GMT


@blurymind you misunderstood me 😉
I was pointing out that the issue could be related to this css rule in the master branch, not the electron one 😛

This css rule will move the right menu buttons when the window's width is lower than 830px, which is when the issue with the arrows seems to be happening.
But I've only been working in the electron branch so far, so I'm not sure what's really happening, I'll let others investigate.

@desplesda
Copy link
Collaborator Author

Comment by blurymind
Monday Aug 13, 2018 at 07:38 GMT


@julsam do we patch it in the nwjs version? I want to focus on maintaining the electron one

@desplesda
Copy link
Collaborator Author

Comment by julsam
Saturday Aug 25, 2018 at 12:21 GMT


@blurymind it's not a major bug, so i'm not sure patching the nwjs is worth it since the plan is to go full electron in the long term. There's a lot more important issues to fix in the nwjs version anyway (but i'm more focused on the electron branch myself).

@blurymind
Copy link
Owner

is this bug still here? I cant seem to reproduce it

@FaultyFunctions
Copy link
Contributor

This seems to be fixed and has been inactive for a while. I'm closing the issue but feel free to re-open if need be!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants