Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron: Tab order in node editor #89

Closed
desplesda opened this issue Sep 18, 2019 · 10 comments
Closed

electron: Tab order in node editor #89

desplesda opened this issue Sep 18, 2019 · 10 comments

Comments

@desplesda
Copy link
Collaborator

Issue by rdominick
Sunday Jan 27, 2019 at 03:28 GMT
Originally opened as InfiniteAmmoInc/Yarn#89


If you hit TAB from the tags line on the node editor, the focus goes nowhere, It should send the cursor to the node body.

If you hit TAB many times from the tags line, it eventually puts focus on the node name. The editor is never selected.

@desplesda
Copy link
Collaborator Author

Comment by blurymind
Sunday Jan 27, 2019 at 11:31 GMT


that is actually a missing feature :)
Pull requests to add it are welcome

@desplesda
Copy link
Collaborator Author

Comment by rdominick
Sunday Jan 27, 2019 at 15:37 GMT


Since this is the way it worked before the toolbar, it's more of a bug, don't you think? :)

@desplesda
Copy link
Collaborator Author

Comment by blurymind
Wednesday Feb 06, 2019 at 19:50 GMT


I think what happens is that all the buttons are now taking focus in the order, which is natural when there is now a new element there

@desplesda
Copy link
Collaborator Author

Comment by rdominick
Thursday Feb 07, 2019 at 05:02 GMT


Traditionally, in a UI with a toolbar, the toolbar buttons are not selectable via keyboard -- those buttons are shortcuts for menu items which have their own keyboard shortcuts.

If the toolbar buttons are getting focus than there is no visual feedback of that fact. You can trigger the current toolbar button with the spacebar, but the results are... unpredictable

Also, the node body is now never tabbed to/selected, even though it is still an element that should naturally have a place in the tab order.

I'm not arguing just to argue; I honestly want the UI to be as good as it can be. This is a major usability issue for users like me who don't like to take their hands off the keyboard once they start typing.

@desplesda
Copy link
Collaborator Author

Comment by blurymind
Thursday Feb 07, 2019 at 08:52 GMT


fixed via InfiniteAmmoInc/Yarn@dc6588e
and InfiniteAmmoInc/Yarn@37a3e6f

please confirm if that works for you :)
tabbing from tags will now always tab to editor

@desplesda
Copy link
Collaborator Author

Comment by rdominick
Thursday Feb 07, 2019 at 23:20 GMT


Yes, it works quite well.

@desplesda
Copy link
Collaborator Author

Comment by blurymind
Friday Feb 08, 2019 at 00:13 GMT


In that case let's close this issue :)

@desplesda
Copy link
Collaborator Author

Comment by rdominick
Friday Feb 08, 2019 at 00:16 GMT


Actually, I did find an issue while I was messing around: since the focus is triggered on blur, if you shift-tab away from the tags line it tabs forward to the editor instead...

@desplesda
Copy link
Collaborator Author

Comment by blurymind
Friday Feb 08, 2019 at 08:57 GMT


Actually, I did find an issue while I was messing around: since the focus is triggered on blur, if you shift-tab away from the tags line it tabs forward to the editor instead...

I fixed this properly now. Will do the commit tonight :)

@desplesda
Copy link
Collaborator Author

Comment by blurymind
Friday Feb 08, 2019 at 19:27 GMT


should be fixed now, try again :)

via
InfiniteAmmoInc/Yarn@c54dd56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants