Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to always hide tabs, even if sidebery is closed, and option to hide the entire address bar. #141

Open
aspizu opened this issue Apr 11, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@aspizu
Copy link

aspizu commented Apr 11, 2024

  1. Add a option to hide tabs even if sidebery is closed.
  2. Add a option to hide the address bar / toolbar.

Thank you for this theme, I love it.

@aspizu aspizu added the enhancement New feature or request label Apr 11, 2024
@momoe
Copy link

momoe commented Apr 16, 2024

I just updated to the latest release of EdgeFr, and giving this 'sidebery' business a whirl. I don't know if we need a 3rd party addon for this if the same experience can be simply replicated from the CSS already. Please take a look at https://www.reddit.com/r/FirefoxCSS/comments/obw2wm/edgestyle_vertical_tabs_for_firefox_with_tab/

Again, I'm not tooo familiar with all the features sideberry offers and/or if the additional bloat is really worth it, so let me know if I'm missing out on something truly great.

@momoe
Copy link

momoe commented Apr 16, 2024

P.S. if there's some way to include the focused singular tab as the header like Edge, would be more complete

image

@bmFtZQ
Copy link
Owner

bmFtZQ commented Apr 19, 2024

  1. Add a option to hide tabs even if sidebery is closed.

    1. Add a option to hide the address bar / toolbar.

Thank you for this theme, I love it.

The first one may not be possible without duplicating all of the code used in hiding the tabs toolbar, which I would prefer not to do if I can. You could modify the chrome/tweaks/hide-tabs-bar.css file on your system, which would just involve replacing the selector:

/* FROM: */
:root:not([customizing]):has(#sidebar-box[sidebarcommand="[extention-id]"]:not([hidden])) {
  /* ... */
}

/* TO: */
:root:not([customizing]) {
  /* ... */
}

For the second one, do you mean permanently? Or like an auto hide option where it is activated when moving the mouse to the top? There is already the full screen mode where this possible, though that wouldn't work for a "windowed" mode.

@aspizu
Copy link
Author

aspizu commented Apr 19, 2024

  1. can't you use the new nested seelctors in css to do that?

  2. auto-hide

@bmFtZQ
Copy link
Owner

bmFtZQ commented Apr 19, 2024

  1. can't you use the new nested seelctors in css to do that?

  2. auto-hide

I already use the nested rules, but you can't really mix media rules (used for tweaks) with regular rules (which target the elements themselves) easily.

The problem is that only one selector type can be applied without breaking functionality of the other option: always hidden OR hidden when Sidebery is active.

I can't change the selectors based on media rules, unless CSS adds support for variables inside selectors or mixins (reusable styles). The only way I know this can be accomplished is by duplicating the contents of the rules and putting them in separate media queries.

For the auto-hiding nav-bar, I will look into it but it may be out of scope of this theme.

@aspizu
Copy link
Author

aspizu commented Apr 19, 2024

could you switch to using SCSS, i think its super-set so shouldn't be an issue.

@bmFtZQ
Copy link
Owner

bmFtZQ commented Apr 19, 2024

could you switch to using SCSS, i think its super-set so shouldn't be an issue.

I have thought about using a preprocessor, but that would make is a bit harder for others to modify the CSS as SCSS doesn't seem to support outputting nested CSS code and others may not have SCSS installed or know how to use it.

@bmFtZQ
Copy link
Owner

bmFtZQ commented Apr 19, 2024

I just updated to the latest release of EdgeFr, and giving this 'sidebery' business a whirl. I don't know if we need a 3rd party addon for this if the same experience can be simply replicated from the CSS already. Please take a look at https://www.reddit.com/r/FirefoxCSS/comments/obw2wm/edgestyle_vertical_tabs_for_firefox_with_tab/

Again, I'm not tooo familiar with all the features sideberry offers and/or if the additional bloat is really worth it, so let me know if I'm missing out on something truly great.

The theme used in the Reddit post you linked uses the Tab Center Reborn extension, which is similar to Sidebery (but with less options/features, e.g. tab tree structure).

I was originally going to make my own version of that theme (I even submitted some bug fixes and features), but I started using Sidebery due to the features it offers, so I made a theme for that instead.

P.S. if there's some way to include the focused singular tab as the header like Edge, would be more complete

image

I will give the title bar appearance a try and see if that can be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants