Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invisible buttons and misalignments everywhere #176

Open
edge261 opened this issue Nov 26, 2024 · 4 comments
Open

Invisible buttons and misalignments everywhere #176

edge261 opened this issue Nov 26, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@edge261
Copy link

edge261 commented Nov 26, 2024

Description

After updating to version 133, minimize and maximize buttons are invisible. The tablet mode for some reason is enabled, and the searchbox is misaligned when is focused

Include screenshot / video recording if possible.

Configuration

  • Firefox Version: 133
  • OS: Windows 11
  • Tweaks enabled:
    image
@edge261 edge261 added the bug Something isn't working label Nov 26, 2024
bmFtZQ added a commit that referenced this issue Nov 27, 2024
@bmFtZQ
Copy link
Owner

bmFtZQ commented Nov 27, 2024

Could you try to update to the latest commit of the theme. The tab height should be fixed now, though I cannot replicate the other issues.

@MeguMario
Copy link

MeguMario commented Nov 27, 2024

I found out that the window control will have its opacity set to 0 if you have widget.windows.mica set to true
Screenshot 2024-11-27 220924

Set it to false or forcing the window controls's opacity to the value of 100 will restore the buttons
Screenshot 2024-11-27 220941

The css lines that handle the window control hiding can be found at line 39 of chrome://browser/skin/browser.css, I will leave a snippet of that here

@media (-moz-windows-mica) {
      &:not([lwtheme]) {
        background-color: transparent;

        /* Accent color in titlebar overrides Mica. */
        @media not (-moz-windows-accent-color-in-titlebar) {
          /* Hide the Firefox buttons since Windows draws their own.
           * FIXME(emilio): Find a way of hiding the native buttons, or make them
           * taller, this is very hacky. */
          .titlebar-buttonbox {
            opacity: 0;
          }
        }
      }
    }

Alternatively, adding back the Mica option (removed in 708e4e8) and enable widget.windows.mica and browser.theme.native-theme in about:config, the window control will now appear everytime the browser window is active. And as a bonus, Windows 11's Mica effect is now back in working order like it was before its removal from the theme, now without using third party app (tho you can still use one to change the backdrop to Acrylic)

Native Mica
image

With OpenGlass
image

@WildByDesign
Copy link

Alternatively, adding back the Mica option (removed with 708e4e8) and enable widget.windows.mica and browser.theme.native-theme in about:config, the window control will now appear everytime the browser window is active.

That is beautiful. It’s good to see it back in 133.

@bmFtZQ A little off-topic for this issue, but would you be able to restore the mica tweak again?

@edge261
Copy link
Author

edge261 commented Nov 27, 2024

Could you try to update to the latest commit of the theme. The tab height should be fixed now, though I cannot replicate the other issues.

yeah, it's now fixed. updating fixed the other stuff too...

and yes, I agree, restore the mica tweak please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants