Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beadandó ill. laborjegy mező csak egész számot fogadjon el #126

Closed
jmarton opened this issue Sep 23, 2018 · 2 comments
Closed

Beadandó ill. laborjegy mező csak egész számot fogadjon el #126

jmarton opened this issue Sep 23, 2018 · 2 comments
Assignees
@lordblendi
Labels
enhancement quick win

Comments

@jmarton
Copy link
Member

jmarton commented Sep 23, 2018

@tsvetlin javaslata bme-db-lab/szglab5-backend#106 kapcsán:

A beadandó ill. laborjegy input fieldbe csak egész számokat lehessen beírni.
@lordblendi
Copy link
Member

Erdekesseg: a html5 input type="number" csak nem enged szamonkon kivul mast beirni (illetve par irasjelet igen). De nem lehet egesz szamra allitani. Ha adok neki min/max erteket, akkor csak a jobb oldali valtoval (nyilak az input jobb oldalan), csak azt tudom valtoztatni.

Ha teljesen biztos validalast akarunk, akkor javascripttel tudom ellenorizni a beirt szoveget (regex). Melyik legyen @jmarton?

@lordblendi lordblendi self-assigned this Oct 3, 2020
lordblendi added a commit that referenced this issue Oct 3, 2020
@lordblendi
partial fix for #126
d93d4a0
@lordblendi lordblendi mentioned this issue Oct 3, 2020
Closed
@jmarton
Copy link
Member Author

jmarton commented Oct 3, 2020

@lordblendi legyen regexp (^[1-5]$). Jól sejtem, hogy a validáló kódot rákötni is van valami modern, 1-soros megoldás.

@lordblendi lordblendi mentioned this issue Oct 3, 2020
Merged
13 tasks
jmarton pushed a commit that referenced this issue Oct 8, 2020
@lordblendi
Több issue, bug javítása. Kód tisztítása (#129)
1ceeb57 
* show neptunCourseCodein table

* fix missing margin

* move visualization to a separate component

* move body calculation to group level

* move generate actions to group level

* calculate event data in demostrator group data

* adjust padding a bit

* calculate course cod in event model

* remove empty lines

* do sorting on group data level

* sorted events by course code

* remove coursecode from table

* code cleanup

* remove autofocus

* fix #114

* adjust paddings

* css whitespace cleanup

* partial fix for #126

* adjust margins

* fix semester field

* adjust styling of scss files

* fix #109

* added subroutes for demonstrator group page

* move demonstrator-group component into demonstrator/detail page

* adjust lock files

* moved demonstrator-student to specific route

* adjust toggles

* adjust more toggles

* remove unused components

* reorganize directory settings components

* clean more of demonstrator

* added more evaluator routes

* left menu work without id

* remove commented template

* added evaluator index and tofix pages

* WIP new evaluator routes

* WIP fixed booked page

* evaluator - finish booked pages

* cleaning code

* move entry test helpers

* adjust demonstrator code, remove unused file

* move around the menu component files

* move around student laboratory files

* move around staff laboratory files

* add new routes for directory pages

* save search to directory queryparams

* adjust sendActions

* fix subroute issues with IDs

* remove bug with toggleproperty

* remove unused file

* separate second attempts per group

* adjust some paddings

* fix wrong component name

* WIP handout download link

* WIP2

* adjust file download

* fix import

* demonstrator sort groups by date

* after date sort by courseCode too

* added error handling for handout download

* parse error from response

* add an extra catch

* adjust unnecessary : characters
@jmarton jmarton closed this as completed Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lordblendi lordblendi

Labels
enhancement quick win
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lordblendi @jmarton