Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurability #47

Closed
bminixhofer opened this issue Feb 26, 2021 · 1 comment
Closed

Configurability #47

bminixhofer opened this issue Feb 26, 2021 · 1 comment
Labels
P2 Medium priority

Comments

@bminixhofer
Copy link
Owner

There should be options which the user can pass:

  • upon initializing the Tokenizer / Rules with an extra method (Rust) or keyword arguments (Python).
  • with a method set_options at any time afterwards.

This is fairly straightforward to implement. Currently I think the only use case for options is a whitelist once spellchecking (#2) is implemented.

@bminixhofer bminixhofer added the P2 Medium priority label Feb 26, 2021
@bminixhofer bminixhofer mentioned this issue Feb 26, 2021
5 tasks
@bminixhofer
Copy link
Owner Author

bminixhofer commented Apr 8, 2021

This would be easy to implement now, but is not necessary anymore because:

  • The Rules will not get any options to allow collecting into Rules from an iterator over Rule and there are no options that really make sense on the set.
  • The Tokenizer will be split up into parts (Modularizing the crate #50), each of which will get options if appropriate and needed.

In summary, with the structure as it is now, options are not needed, but once (if) they are needed they'll be easy to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium priority
Projects
None yet
Development

No branches or pull requests

1 participant