Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release at least one version that supports Node 12.22 #90

Closed
bmish opened this issue Oct 9, 2022 · 3 comments
Closed

Release at least one version that supports Node 12.22 #90

bmish opened this issue Oct 9, 2022 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@bmish
Copy link
Owner

bmish commented Oct 9, 2022

Will unblock:

@bmish bmish added the enhancement New feature or request label Oct 9, 2022
@bmish bmish added this to the v1.0.0 milestone Oct 9, 2022
@bmish bmish changed the title Release at least one version that supports Node 12 Release at least one version that supports Node 12.22 Oct 9, 2022
@bmish
Copy link
Owner Author

bmish commented Oct 9, 2022

Closing since this is too inconvenient. We would have to:

  • Remove 9 usages of optional chaining
  • Downgrade a bunch of dependencies

@bmish bmish closed this as completed Oct 9, 2022
@bmish bmish reopened this Oct 11, 2022
@bmish
Copy link
Owner Author

bmish commented Oct 11, 2022

This would help unblock adoption in these repos that still support Node 12:

  • eslint-plugin-ava
  • eslint-plugin-jest-formatting
  • eslint-plugin-qunit
  • eslint-plugin-regexp
  • eslint-plugin-unused-imports

@bmish
Copy link
Owner Author

bmish commented Oct 30, 2022

Closing because we can usually get away with running this tool (and other linting) on only the latest Node version during CI.

@bmish bmish closed this as completed Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant