Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Changing" parameter type from dynamic to Object? should not be a breaking change #172

Closed
devmil opened this issue Jan 31, 2024 · 0 comments · Fixed by #173
Closed

"Changing" parameter type from dynamic to Object? should not be a breaking change #172

devmil opened this issue Jan 31, 2024 · 0 comments · Fixed by #173
Labels
bug Something isn't working

Comments

@devmil
Copy link
Member

devmil commented Jan 31, 2024

Describe the bug
Currently changing the parameter type from dynamic to Object? is detected as a breaking change.

To Reproduce
Change the parameter type from dynamic or nothing to Object?.
See dart-archive/http2#140 (comment)

Actual and Expected behavior
This type of change should be a minor change

System info (please complete the following information):

  • Output of dart --version
    Dart SDK version: 3.2.6 (stable) (Wed Jan 24 13:41:58 2024 +0000) on "macos_arm64"
  • dart_apitool version (dart-apitool --version)
    0.17.0
@devmil devmil added the bug Something isn't working label Jan 31, 2024
@devmil devmil mentioned this issue Jan 31, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Treat dynamic and object equivalent for inflowing usages devmil/dart_apitool_fork
1 participant
@devmil