Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading error logs in Settings::fillEmptySettingsWithDefaults() #17

Open
BastusIII opened this issue Feb 1, 2018 · 1 comment
Open

Comments

@BastusIII
Copy link

There is an error logged each time Settings::fillEmptySettingsWithDefaults() is called, if there are no default settings files found under the relative path "resources/<default_settings_filename>".
This error is logged also if a settings file is found under CMAKE_JOYNR_SETTINGS_INSTALL_DIR.

As the constructors of WebSocketSettings and others call Settings::fillEmptySettingsWithDefaults(), each time one of those settings instances is created, this error is logged.

[error] Settings Could not read settings file: resources/default-websocket.settings: cannot open file

Please remove this log message by checking if the paths exists before, or reduce the log-level.

@ghost
Copy link

ghost commented Feb 13, 2018

Thanks for the analysis and for reporting the issue. Indeed the error is misleading, it would be nice if you can make a pull-request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant