From de61400caf1fff5cb97ea489e7eb75b07d8e3a69 Mon Sep 17 00:00:00 2001 From: "Shane F. Carr" Date: Mon, 27 Jan 2025 06:26:05 -0800 Subject: [PATCH 1/2] Add Eq, Ord impls on FiniteF64 --- src/primitive.rs | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/src/primitive.rs b/src/primitive.rs index 623757ea..2d5e5e15 100644 --- a/src/primitive.rs +++ b/src/primitive.rs @@ -1,5 +1,7 @@ //! Implementation of the FiniteF64 primitive +use core::cmp::Ordering; + use crate::{TemporalError, TemporalResult}; use num_traits::{AsPrimitive, FromPrimitive, PrimInt}; @@ -215,6 +217,20 @@ impl PartialOrd for FiniteF64 { } } +impl Eq for FiniteF64 {} + +impl Ord for FiniteF64 { + fn cmp(&self, other: &Self) -> Ordering { + match self.0.partial_cmp(&other.0) { + Some(ordering) => ordering, + None => { + debug_assert!(false, "could not compare fininte f64: {self} {other}"); + Ordering::Equal + } + } + } +} + #[cfg(test)] mod tests { use super::FiniteF64; From 3a68d54b59b4b2fff2336fd87f7d4ad94a056a02 Mon Sep 17 00:00:00 2001 From: "Shane F. Carr" Date: Tue, 28 Jan 2025 05:05:40 +0100 Subject: [PATCH 2/2] Update src/primitive.rs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: José Julián Espina --- src/primitive.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/primitive.rs b/src/primitive.rs index 2d5e5e15..59436c46 100644 --- a/src/primitive.rs +++ b/src/primitive.rs @@ -224,7 +224,7 @@ impl Ord for FiniteF64 { match self.0.partial_cmp(&other.0) { Some(ordering) => ordering, None => { - debug_assert!(false, "could not compare fininte f64: {self} {other}"); + debug_assert!(false, "could not compare finite f64: {self} {other}"); Ordering::Equal } }