Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No doctype node? #27

Open
icefoxen opened this issue Dec 17, 2018 · 1 comment
Open

No doctype node? #27

icefoxen opened this issue Dec 17, 2018 · 1 comment

Comments

@icefoxen
Copy link

icefoxen commented Dec 17, 2018 •
edited
Loading

Hi, is there a way to have a <!DOCTYPE html> node? The macro parser appears to choke on the !, and I don't seem to find anything like it in the typed_html::elements namespace. #18 does suggest that trying to do it might be a little squirrelly, but maybe there's a way to add it to the DOM tree after the fact or such? idk.

Just wondering if there were a good way to do it. Thank you!
@bodil
Copy link
Owner

bodil commented Dec 20, 2018

This would have to depend on #18, as I'm not sure it's meaningful to have a html!() block with just a doctype node.

I'm also not sure it should be there at all, because it has no meaning when rendering to the DOM, only to strings, and it might be better if adding it were left to the string renderer, or possibly even the consumer of the string renderer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bodil @icefoxen