fix(#6): Headers now working correctly. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nted to add a header it would create a new header object and then discard it when we tried to later add something to it. It would also return a new header everywhere because calling `request.header` would construct a new one.
|
Just as a random question, do you think this would also fix #5? |
Hmm, depends on how the Response.json is implemented. |
|
@KaydaFox you can copy the changes I've made to your app and see if it fixes it. I also recommend replacing |
|
@bogeychan any chance to get this merged? |
|
Well @rubnogueira next version of Elysia will support Node so you might be able to just use that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Headers are should be persisted. Before each time we wanted to add a header, it would create a new header object and then discard it when we tried to later add something to it.
It would also return a new header everywhere because calling
request.headerwould construct a new one.I'm not sure if this breaks anything else, but from my testing on my app it seems to be working fine.
Fixes: #6