Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slice Geometry doesn't respect ROIs and then complains there isn't an ROI when there is one #345

Closed
mdoube opened this issue Apr 26, 2024 · 0 comments · Fixed by #346
Closed

Slice Geometry doesn't respect ROIs and then complains there isn't an ROI when there is one #345

mdoube opened this issue Apr 26, 2024 · 0 comments · Fixed by #346
Assignees
@mdoube

Comments

@mdoube
Copy link
Member

mdoube commented Apr 26, 2024

Describe the bug
Slice Geometry doesn't respect ROIs and then complains there isn't an ROI when there is one

To Reproduce
Steps to reproduce the behavior:

  1. Open an image, set a rectangular ROI, run Slice Geometry
  2. Clear the ROI and run Slice Geometry again

Expected behavior
Slice Geometry runs using either the whole image if there is no ROI, or only the pixels inside the ROI if an ROI is set

Additional context
https://forum.image.sc/t/second-moment-of-area-imin-and-imax/47098/14
@mdoube mdoube self-assigned this Apr 26, 2024
mdoube added a commit that referenced this issue Apr 26, 2024
@mdoube
Slice Geometry: Handle ROIs (or lack of them) more gracefully
4b9ed14 
Seems like there has been a regression or change of behaviour in
IJ, around ROIs and getting bounds.

This code change makes ROI handling more explicit and uses only
ImagePlus methods (not ImageProcessor or ImageStack).

Fixes #345
@mdoube mdoube mentioned this issue Apr 26, 2024
Merged
@mdoube mdoube linked a pull request Apr 26, 2024 that will close this issue
Slice Geometry: Handle ROIs (or lack of them) more gracefully #346
Merged
mdoube added a commit that referenced this issue Apr 26, 2024
@mdoube
Slice Geometry: Handle ROIs (or lack of them) more gracefully
8e91419 
Seems like there has been a regression or change of behaviour in
IJ, around ROIs and getting bounds.

This code change makes ROI handling more explicit and uses only
ImagePlus methods (not ImageProcessor or ImageStack).

Fixes #345
mdoube added a commit that referenced this issue May 14, 2024
@mdoube
Slice Geometry: Handle ROIs (or lack of them) more gracefully (#346)
b9da758 
Seems like there has been a regression or change of behaviour in
IJ, around ROIs and getting bounds.

This code change makes ROI handling more explicit and uses only
ImagePlus methods (not ImageProcessor or ImageStack).

Fixes #345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdoube mdoube

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Slice Geometry: Handle ROIs (or lack of them) more gracefully bonej-org/BoneJ2
1 participant
@mdoube