Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool: detect links in the documentation content that lead to HTTP 404 errors #594

Open
tbouffard opened this issue Jun 30, 2023 · 0 comments
Assignees

Comments

@tbouffard
Copy link
Member

tbouffard commented Jun 30, 2023

IMPORTANT: #430 lists some broken links and provide more context

Internal links are done using Antora xref and we are validating xref on PR preview and when building the whole site.

However, we don't check that external site are valid. We should run a tool at least periodically in the whole site.
It could be built and serve locally if this speedup the process, or we could retrieve the whole content from Netlify (download zip archive).

Netlify

Other solutions

Strategy to test the tools

WIP list

  • if allowed by the tool, use a locally built site
  • start by checking a single component version
  • disable the "edit this page" link (may be possible by setting an asciidoc attribute globally in the antora-playbook.yml, probably won't work for branches were "page-editable: true" in antora.yml). --> use the --hide-edit-page-links option of the "build preview" script
  • ignore some urls that appear in all pages (logo bonitasoft, logo of tools)
  • do not generate redirect static page. This is not for production and we don't want to test the Antora redirects generation. Such static page include canonical and link to the production site that we don't want to check.
  • generate page with html extension to let the tools browse the page on the filesystem

Detected problems with htmltest --> URLs to ignore

@tbouffard tbouffard self-assigned this Sep 1, 2023
rbioteau pushed a commit to bonitasoft/bonita-test-toolkit-doc that referenced this issue Sep 6, 2023
This ensures that the xref targets the right bonita version supported by
the test-toolkit version. It doesn't depend on bonita "latest" version.

### Notes

Detected while investigating tools for
bonitasoft/bonita-documentation-site#594
Completness of the fix: check
https://github.com/search?q=repo%3Abonitasoft%2Fbonita-test-toolkit-doc+%22xref%3Abonita%22&type=code
(references exist prior merging this PR)
@tbouffard tbouffard moved this from In Progress to Todo in Bonita documentation site - work in progress Mar 1, 2024
@tbouffard tbouffard moved this from Todo to In Progress in Bonita documentation site - work in progress Apr 3, 2024
@tbouffard tbouffard pinned this issue Aug 14, 2024
rbioteau pushed a commit to bonitasoft/bonita-doc that referenced this issue Oct 28, 2024
The former URL was still used and hardcoded in the "Studio Update" page.

### Notes

Detected with
bonitasoft/bonita-documentation-site#618 as part
of bonitasoft/bonita-documentation-site#594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant