Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with jQuery 3.1.0 #120

Open
pratyushpundir opened this issue Oct 29, 2016 · 3 comments
Open

Issues with jQuery 3.1.0 #120

pratyushpundir opened this issue Oct 29, 2016 · 3 comments

Comments

@pratyushpundir
Copy link

pratyushpundir commented Oct 29, 2016

I seem to be having an issue running Slippry with jQuery 3.1.0.

Consider the markup:

<section class="some-slider">

    {% for slide in slides %}
    <!-- Single Slide -->
    <article>

        <!-- Slide Image -->
        <div class="image-content">
            <img src="{{ slide.path }}" alt="{{ slide.title }}">
        </div>
        <!-- Slide Image -->

    </article>
    <!-- Single Slide -->
    {% endfor %}

</section>

and the JS:

$('.some-slider').slippry({
    slippryWrapper: '<section class="sy-box some-slider-wrapper">',
    elements: 'article',
    adaptiveHeight: false,
    autoHover: false,
    auto: false,
    captions: false,
    transition: 'horizontal',
    loop: true,
    responsive: true
});

jQuery squacks with the following error:

Uncaught TypeError: Cannot read property 'indexOf' of undefined

The issue goes away if I use background images instead of <img> tags themselves. I do not wish to use background images but the actual <img> tags. When I inspect the page markup using devTools, I can see that all images loaded successfully without any issues. Even hard coding image paths still causes the issue.

Any idea why this might be occurring?

@pratyushpundir
Copy link
Author

Please note that the issue does not occur when using jQuery 2.2.4.

@khflab
Copy link

khflab commented Jan 13, 2017

the main question is: slippry supports jquery 3.x.x?

@biphobe
Copy link

biphobe commented Apr 17, 2017

Works fine when used with jQuery v3.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants