Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative paths for images #90

Open
Anahkiasen opened this issue Sep 9, 2015 · 2 comments
Open

Use relative paths for images #90

Anahkiasen opened this issue Sep 9, 2015 · 2 comments
Labels

Comments

@Anahkiasen
Copy link

The way the images are included at the moment with absolute URLs:

background: url("/images/sy-loader.gif") 50% 50% no-repeat;

Make it very hard to pack Slippry with something like Webpack, couldn't relative URLs be used there, to more easily let build systems know where the images are?

@sftsk
Copy link
Member

sftsk commented Sep 11, 2015

If you use the sass version you can easily overwrite this:

$spinner_url: '/images/sy-loader.gif' !default;
$arrows_url: '/images/arrows.svg' !default;

There has been talk about this in #62 already, perhaps relative would be easier for some?

@sftsk sftsk added the question label Sep 11, 2015
@mgsmus
Copy link

mgsmus commented May 6, 2016

How about move images folder to dist and use "images/" instead of "/images/" ? Final folder structure could be like this:

slippry.css
slippry.min.js
images/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants