Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xorshift generators #58

Open
heitorPB opened this issue Oct 13, 2019 · 4 comments
Open

Xorshift generators #58

heitorPB opened this issue Oct 13, 2019 · 4 comments

Comments

@heitorPB
Copy link

I found the Xorshift Wikipedia page and saw that Boost doesn't have Marshaglia's nor Vigna's generators.

Is there a reason for that? If not, I'd like to request those :) I'd like to help adding them to Boost (if that's the case), but keep in mind that I'm not an expert in PRNGs.

@swatanabe
Copy link
Collaborator

swatanabe commented Oct 14, 2019 via email

@degski
Copy link

degski commented Oct 15, 2019

I'm literally heading for the door for an international trip. I need to remove some things (xoroshiro128plusshixo, xoroshiro128plusshixostar and xoroshiro128plusshixostarshixo (see readme)) from the implementation, then, as far as I can see it's good to go. As a bonus, it provides splitmix64, which is recommended by Vigna for seeding (so, I implemented it that way). I'll get back to it later.

@heitorPB
Copy link
Author

That's great, @degski!

I quickly saw your code and noticed you implemented only the Xoroshiros. Is there a reason for not including the xoshiros? I'm particularly interested in xoshiro256** (and curious about the the variantes with 512 and 1024 bits of space).

@heitorPB
Copy link
Author

heitorPB commented Nov 4, 2019

ha, sorry @degski , I didn't look enough in your code previously.. all those generators are in your code. How can I help to add your code to Boost?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants