Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete 100% test coverage. #41

Open
borgar opened this issue Jul 3, 2016 · 2 comments
Open

Complete 100% test coverage. #41

borgar opened this issue Jul 3, 2016 · 2 comments

Comments

@borgar
Copy link
Owner

borgar commented Jul 3, 2016

Code coverage measurements report that the coverage is 97%. Let's push this through to a perfect 100%. If only for the bragging rights.

@borgar borgar self-assigned this Jul 3, 2016
@borgar borgar removed their assignment Feb 12, 2019
@waldyrious
Copy link

@borgar is there a coverage report that's publicly accessible and continually updated? (In other words, is there, or could there be, a code coverage CI?)

It would probably be a good first issue for new contributors to help complete the missing coverage, and such a tool would be very helpful in that regard.

@borgar
Copy link
Owner Author

borgar commented Apr 12, 2021

There is no CI backing this, but I suppose I could set up actions here. Coverage can be gotten to using npm run coverage which runs the tests and emits a coverage report. Here is one for the "next version" branch @ #69:

---------------|---------|----------|---------|---------|--------------------
File           | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
---------------|---------|----------|---------|---------|--------------------
All files      |   98.67 |    93.73 |   96.94 |   98.76 |
 src           |   95.68 |    87.25 |   95.71 |   95.92 |
  Ribbon.js    |     100 |    84.62 |     100 |     100 | 93-105
  VDOM.js      |   93.75 |    87.18 |   93.75 |   94.51 | 60,162-163,181,212
  constants.js |     100 |      100 |     100 |     100 |
  html.js      |   95.74 |    88.41 |     100 |   95.65 | 69-76,159,165
  index.js     |     100 |      100 |     100 |     100 |
  re.js        |   88.46 |    84.62 |   83.33 |   88.46 | 25,38,65
 src/textile   |     100 |     96.4 |     100 |     100 |
  attr.js      |     100 |    98.65 |     100 |     100 | 86
  deflist.js   |     100 |      100 |     100 |     100 |
  flow.js      |     100 |    95.54 |     100 |     100 | 75,156,189,215,329
  glyph.js     |     100 |      100 |     100 |     100 |
  list.js      |     100 |     93.1 |     100 |     100 | 52,130
  phrase.js    |     100 |    97.83 |     100 |     100 | 234,258
  re_ext.js    |     100 |      100 |     100 |     100 |
  table.js     |     100 |       94 |     100 |     100 | 29,92,114
---------------|---------|----------|---------|---------|--------------------

I am not actually sure that the test coverage is lacking, per-se. Many (or all) of these may be due to unreachable code (such as unused member functions) rather than missing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants