Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI update can be triggered twice #184

Open
RobinTail opened this issue Aug 16, 2023 · 0 comments · Fixed by #186
Open

UI update can be triggered twice #184

RobinTail opened this issue Aug 16, 2023 · 0 comments · Fixed by #186
Labels
bug Something isn't working

Comments

@RobinTail
Copy link
Collaborator

the UI update can be triggered twice (by action and by polling).
It needs a lock.

2023-08-16 23:05:21,643 - octoprint.plugins.octorelay - INFO - Received the API command update with parameters: {'pin': 'r3', 'command': 'update'}
2023-08-16 23:05:21,643 - octoprint.plugins.octorelay - DEBUG - Requested to switch the relay r3
2023-08-16 23:05:21,759 - octoprint.plugins.octorelay - DEBUG - Toggling the relay r3 on pin 18
2023-08-16 23:05:21,760 - octoprint.plugins.octorelay - DEBUG - Updating the UI
2023-08-16 23:05:21,799 - octoprint.plugins.octorelay - DEBUG - relay: r3 has changed its pin state
2023-08-16 23:05:21,799 - octoprint.plugins.octorelay - DEBUG - Updating the UI

improved logging helped to reveal it.

Originally posted by @RobinTail in #183 (comment)

@RobinTail RobinTail added the bug Something isn't working label Aug 16, 2023
@RobinTail RobinTail pinned this issue Aug 23, 2023
@RobinTail RobinTail mentioned this issue Aug 26, 2023
@RobinTail RobinTail linked a pull request Aug 26, 2023 that will close this issue
@RobinTail RobinTail unpinned this issue Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant