Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Request: Add Type Annotations #1362

Open
garrett-s-wininger opened this issue Dec 28, 2021 · 3 comments
Open

Enhancement Request: Add Type Annotations #1362

garrett-s-wininger opened this issue Dec 28, 2021 · 3 comments

Comments

@garrett-s-wininger
Copy link

Hello all,

I'm currently working on a Pysa contribution to annotate potential places where user-controlled data may be received from web servers. Bottle is one of the frameworks that caught our attention and to supplement the contribution, I'd love it if we could provide type annotations for the library as they are generally required to get good signal from Pysa analysis. I've got a PYI stub for Pyre I'm working on to get my analysis to work so was wondering if the maintaining team here would be willing to accept it once complete or, if not, whether there would be any issue trying to send it to the upstream Python typeshed.

Looking forward to hearing back!

@defnull
Copy link
Member

defnull commented May 27, 2022

I do not have any experience with Pyre so maintaining these definitions might be tricky in the long run. Contributing to typeshed might be a more sustainable option.

@ilrico
Copy link

ilrico commented Dec 17, 2022

Indeed typeshed studs would enable pyright support right away.
pyright issue with bottle.FormsDict

@defnull
Copy link
Member

defnull commented Sep 5, 2024

Starting with 0.13 we are dropping support for ancient python versions. 0.14 (or 1.0) will drop Support for Python 2. This means we can FINALLY start adding type annotations without triggering SyntaxError on older python releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants