Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to compare the marshaled packets with ipmitool's output #43

Open
utkuozdemir opened this issue Dec 17, 2024 · 1 comment
Open

Comments

@utkuozdemir
Copy link
Contributor

Got the idea while fixing 07fafa6, I would suggest adding tests to compare the sent/received payloads of this library with ipmitools, to catch any potential incompatibilities. ipmitool -vv prints the raw payloads - it should be possible to parse the output for the comparison. Or maybe there is a better way.

@bougou
Copy link
Owner

bougou commented Dec 18, 2024

It would be very useful to have these kinds of tests.

I'll try to do that, and PRs are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants