Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error: multiple definition of `disctype'; #16

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

aphex3k
Copy link

@aphex3k aphex3k commented Jan 27, 2023

Fix error

multiple definition of `disctype'; CMakeFiles/friidumplibdir/disc.c.o:(.bss+0x0): first defined here
collect2: error: ld returned 1 exit status

Fixes #10

Michael Henke and others added 4 commits January 27, 2023 15:54
@aphex3k
Copy link
Author

aphex3k commented Jan 28, 2023

Also adds a fairly minimal Dockerfile to build and run friidump.

@ColleagueRiley
Copy link

You could also just make the uisctype variable static instead of just removing it. I think that matches what the original author was trying to go for more. Although I don't see much of a use of it being there myself, I've not looked much into the code.

@vorburger vorburger mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Build
2 participants