Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Plugin crash when no brainglobe atlases available #15

Closed
IgorTatarnikov opened this issue Oct 18, 2023 · 4 comments · Fixed by #14
Closed

[BUG] Plugin crash when no brainglobe atlases available #15

IgorTatarnikov opened this issue Oct 18, 2023 · 4 comments · Fixed by #14
Assignees
@IgorTatarnikov
Labels
bug Something isn't working

Comments

@IgorTatarnikov
Copy link
Member

Describe the bug
Napari plugin crashes if there are no Brainglobe atlases available

To Reproduce
Open the plugin in a fresh install with no Brainglobe atlases available.

Expected behaviour
Plugin should open successfully and prompt user to download an atlas

Computer used (please complete the following information):

  • OS: Linux
  • Version Ubuntu 20.04.6
  • Hardware specs i9-13900K, 32GB RAM, RTX 4080
@IgorTatarnikov IgorTatarnikov added the bug Something isn't working label Oct 18, 2023
@IgorTatarnikov IgorTatarnikov self-assigned this Oct 18, 2023
@IgorTatarnikov IgorTatarnikov linked a pull request Oct 18, 2023 that will close this issue
Basic functionality #14
Merged
15 tasks
@alessandrofelder alessandrofelder mentioned this issue Oct 23, 2023
Open
@alessandrofelder
Copy link
Member

FWIW brainrender-napari has the same issue - once it's solved in one of the repos, we should migrate it to a shared codebase?

Crosslinking brainglobe/brainrender-napari#109

@alessandrofelder alessandrofelder moved this from Backlog to Planned in Core development Nov 24, 2023
@github-project-automation github-project-automation bot moved this from Planned to Done in Core development Nov 28, 2023
@IgorTatarnikov
Copy link
Member Author

Plugin doesn't crash on launch but it would be good to infrom the user that they should download an atlas using brainglobe-atlas-api

@alessandrofelder
Copy link
Member

using atlas api or brainrender-napari!

@saarah815 saarah815 mentioned this issue Aug 5, 2024
Merged
7 tasks
@IgorTatarnikov
Copy link
Member Author

Closed by #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IgorTatarnikov IgorTatarnikov

Labels
bug Something isn't working
Projects
Core development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Basic functionality brainglobe/brainglobe-registration
2 participants
@alessandrofelder @IgorTatarnikov