-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to handling encoded parameters in 7.0.2 #75
Comments
I've been facing something similar too. Might be related to this change here - 6c15df9 |
this works around issue braintree/sanitize-url#75
* pin @braintree/sanitize-url to 7.0.1 this works around issue braintree/sanitize-url#75 * clone newIssue frontend config before mutating it
this works around issue braintree/sanitize-url#75
this works around issue braintree/sanitize-url#75
this works around issue braintree/sanitize-url#75
… Ticket link (#1976) * pin @braintree/sanitize-url to 7.0.1 this works around issue braintree/sanitize-url#75 * clone newIssue frontend config before mutating it
Hello, (internal tracking BTWEB-173) |
I am experiencing the same issue. I see 7.1.0 was released without fixing this breaking change. |
I have the same issue with some URI encoded characters (especially for |
+1 to this, I am also facing this same issue, in 7.1.0. It would be great to have an additional parameter to choose whether to decode the URL or not instead like |
Hello!
I recently upgraded from 7.0.1 to 7.0.2 and had a test fail due to a change in how encoded URL parameters are handled. For example, with 7.0.1 when I pass a URL like http://test.com?encodedParam=foo%2Fbar%2Fbaz into sanitizeUrl I get back http://test.com?encodedParam=foo%2Fbar%2Fbaz.
But with 7.0.2 when passing the same URL in, I now get back http://test.com?encodedParam=foo/bar/baz. I've created a little sample code sandbox here: https://codesandbox.io/p/sandbox/little-butterfly-4n6xzp?file=%2Fpackage.json%3A10%2C38. You can see the change in behavior by switching the version in the package.json in that sandbox.
I've reverted to 7.0.1 for now, but Is this an intended change?
The text was updated successfully, but these errors were encountered: